Move analytics services into extension directory and make dep check stricter. #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
force-pushed
the
stricter-dep-check
branch
2 times, most recently
from
2f4312a
to
b9f312e
Compare
|
@cramforce does this affect the build size? (can you run gulp size if so) |
| @@ -34,6 +34,25 @@ exports.rules = [ | |||
| { | |||
| filesMatching: 'extensions/**/*.js', | |||
| mustNotDependOn: 'src/service/**/*.js', | |||
| whitelist: 'extensions/**/amp-analytics.js', | |||
| }, | |||
| // Files under src must under depend on extensions. | |||
There was a problem hiding this comment.
"must under depend", is that right?
cramforce
force-pushed
the
stricter-dep-check
branch
from
b9f312e
to
1849c91
Compare
cramforce
changed the title
…stricter. The dep check now has a whitelist that allows fine grained whitelisting.
cramforce
force-pushed
the
stricter-dep-check
branch
from
1849c91
to
e108a32
Compare
|
Should not affect build size, but can run. Slightly updated PR to do whitelisting in a way that is more directed. |
|
There are some size changes, but I don't think they come from this. It should only move files around unless you see anything. The dependency graph is unchanged. |
| @@ -125,6 +118,18 @@ Rule.prototype.matchBadDeps = function(moduleName, deps) { | |||
| deps.forEach(dep => { | |||
| this.mustNotDependOn_.forEach(badDepPattern => { | |||
| if (minimatch(dep, badDepPattern)) { | |||
| var inWhitelist = this.whitelist_.some(entry => { | |||
| var pair = entry.split('->'); | |||
|
@cramforce LGTM. awesome feature addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dep check now has a whitelist that allows fine grained whitelisting.