✨ Implement sticky ad bottom type ad on amp-ad #31491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerivq
force-pushed
the
sticky-ad-imp
branch
2 times, most recently
from
a025fe5 to
834c543
Compare
powerivq
force-pushed
the
sticky-ad-imp
branch
from
834c543 to
58bfe14
Compare
powerivq
force-pushed
the
sticky-ad-imp
branch
2 times, most recently
from
7b8fe35 to
e60e15f
Compare
|
Hey @Jiaming-X! These files were changed: Hey @jeffkaufman! These files were changed: |
calebcordry
approved these changes
Dec 18, 2020
| @@ -43,21 +43,23 @@ amp-story-page[xdomain-ad] .i-amphtml-glass-pane { | |||
| } | |||
|
|
|||
| /* TODO(ccordry): refactor centering logic in amp-ad.css and remove this hack. */ | |||
powerivq
force-pushed
the
sticky-ad-imp
branch
6 times, most recently
from
a35fa20 to
c110da8
Compare
|
Merging was blocked by #31756 |
jridgewell
approved these changes
Jan 6, 2021
Not sure why this version is stale. v 7.11 uses `with` syntax, which was changed to `assert` syntax.
powerivq
force-pushed
the
sticky-ad-imp
branch
from
6cc8f2f to
b2b5b4b
Compare
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 19, 2021
)" This reverts commit 5f43080.
samouri
added a commit
that referenced
this pull request
Jan 20, 2021
) * Revert "✨ Implement sticky ad bottom type ad on amp-ad (#31491)" This reverts commit 5f43080. * Upgrade @babel/parser to support import assertions Not sure why this version is stale. v 7.11 uses `with` syntax, which was changed to `assert` syntax. * lint fix Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
PetrBlaha
pushed a commit
to PetrBlaha/amphtml
that referenced
this pull request
Jan 28, 2021
)" (ampproject#32054) * Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" This reverts commit 5f43080. * Upgrade @babel/parser to support import assertions Not sure why this version is stale. v 7.11 uses `with` syntax, which was changed to `assert` syntax. * lint fix Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
github-actions bot
pushed a commit
to mohammed-ibra/amphtml
that referenced
this pull request
Mar 1, 2024
Previous history on prod-config.json: - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1% - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
github-actions bot
pushed a commit
to mohammed-ibra/amphtml
that referenced
this pull request
Apr 1, 2024
Previous history on prod-config.json: - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1% - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
github-actions bot
pushed a commit
to mohammed-ibra/amphtml
that referenced
this pull request
May 1, 2024
Previous history on prod-config.json: - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1% - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
github-actions bot
pushed a commit
to mohammed-ibra/amphtml
that referenced
this pull request
Jun 1, 2024
Previous history on prod-config.json: - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1% - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
github-actions bot
pushed a commit
to mohammed-ibra/amphtml
that referenced
this pull request
Jul 1, 2024
Previous history on prod-config.json: - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1% - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
github-actions bot
pushed a commit
to mohammed-ibra/amphtml
that referenced
this pull request
Aug 1, 2024
Previous history on prod-config.json: - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1% - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
github-actions bot
pushed a commit
to mohammed-ibra/amphtml
that referenced
this pull request
Sep 1, 2024
Previous history on prod-config.json: - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1% - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
github-actions bot
pushed a commit
to mohammed-ibra/amphtml
that referenced
this pull request
Oct 1, 2024
Previous history on prod-config.json: - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1% - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
github-actions bot
pushed a commit
to mohammed-ibra/amphtml
that referenced
this pull request
Nov 1, 2024
Previous history on prod-config.json: - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1% - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
github-actions bot
pushed a commit
to mohammed-ibra/amphtml
that referenced
this pull request
Dec 1, 2024
Previous history on prod-config.json: - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1% - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
github-actions bot
pushed a commit
to mohammed-ibra/amphtml
that referenced
this pull request
Jan 1, 2025
Previous history on prod-config.json: - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1% - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a white background and shadow css, so that the amp-ad sticky ad looks much more like amp-sticky-ad. Ensure resizing works on both amp-ad scenarios.