Add feature to allow adding URL params to the front of the URL. #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,16 +65,23 @@ export function parseUrl(url) { | |||
| * Appends the string just before the fragment part of the URL. | |||
There was a problem hiding this comment.
Not sure if we want to change the comment since it supports adding to the front of the url now
This is needed because some ad servers have (probably for legacy reasons) a behavior, where they treat URL params at the end specially. This is likely because these encode a URL and people can get that wrong. Affects ampproject#2934
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because some ad servers have (probably for legacy reasons) a behavior, where they treat URL params at the end specially. This is likely because these encode a URL and people can get that wrong.
Affects #2934