Validation for amp-kaltura-player. Similar to amp-youtube etc., in this #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
case the data-partner attribute is mandatory and everything else is optional. I would be happy to validate more, e.g., with regexes, but don't know what the specs are for these parameters. Also one small fix in amp-kaltura-player.js itself, where the error message differs from the attribute that's being checked. Also a small edit to the amp-kaltura-player.md file to indicate that data-partner is a mandatory attribute.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case the data-partner attribute is mandatory and everything else
is optional. I would be happy to validate more, e.g., with regexes,
but don't know what the specs are for these parameters.
Also one small fix in amp-kaltura-player.js itself, where the error
message differs from the attribute that's being checked.
Also a small edit to the amp-kaltura-player.md file to indicate that
data-partner is a mandatory attribute.