Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor media-based CE attributes to remove dependency on resource manager #31948

Merged
merged 9 commits into from
Jan 21, 2021
Merged

Refactor media-based CE attributes to remove dependency on resource manager #31948

merged 9 commits into from
Jan 21, 2021

Conversation

dvoytenko
Copy link
Contributor

@dvoytenko dvoytenko commented Jan 13, 2021 •
edited
Loading

Partial for #31915.
Partial for #30719.
Blocked by #32056

TODO:

  • Tests

jridgewell
jridgewell requested changes Jan 14, 2021
View reviewed changes
src/custom-element.js Outdated Show resolved Hide resolved
src/custom-element.js Outdated Show resolved Hide resolved
src/custom-element.js Outdated Show resolved Hide resolved
@dvoytenko dvoytenko mentioned this pull request Jan 15, 2021
Draft
3 tasks
@dvoytenko dvoytenko force-pushed the run3/media-sizes-auto branch 2 times, most recently from 71aba54 to 24978ee Compare January 20, 2021 01:29
samouri
samouri approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some nits, but overall I love this.
It (along with your other recent PRs) are bringing AMP Runtime much closer to (if not basically the same) as Bento components.

src/custom-element.js Show resolved Hide resolved
src/utils/media-query-props.js Outdated Show resolved Hide resolved
src/utils/media-query-props.js Show resolved Hide resolved
@dvoytenko dvoytenko requested a review from jridgewell January 20, 2021 16:54
jridgewell
jridgewell approved these changes Jan 20, 2021
View reviewed changes
src/utils/media-query-props.js Show resolved Hide resolved
src/utils/media-query-props.js Show resolved Hide resolved
@dvoytenko dvoytenko force-pushed the run3/media-sizes-auto branch from 4bc4f6f to e65eba4 Compare January 21, 2021 00:32
@dvoytenko dvoytenko merged commit 8460006 into ampproject:master Jan 21, 2021
@dvoytenko dvoytenko deleted the run3/media-sizes-auto branch January 21, 2021 01:30
@jridgewell jridgewell mentioned this pull request Jan 27, 2021
Closed
PetrBlaha pushed a commit to PetrBlaha/amphtml that referenced this pull request Jan 28, 2021
@PetrBlaha
Refactor media-based CE attributes to remove dependency on resource m…
38bbcc4 
…anager (ampproject#31948)

* Refactor media-based CE attributes to remove dependency on resource manager

* cleanup

* Remove attribute refresh and add tests

* remove applySizesAndMediaQuery

* lints

* make util non-package-private

* Support IE form

* review fixes

* fix removeListener + tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samouri samouri samouri approved these changes

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dvoytenko @jridgewell @samouri @ampprojectbot