✨ Support custom highlight color for text fragments in AMP documents #32591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso add tests. 2. Refactor fetching the ::target-text CSS rules
| for (let i = styles.length - 1; i >= 0; i--) { | ||
| const cssRules = styles[i]./*OK*/ innerHTML; | ||
| const targetTextRules = cssRules.match( | ||
| /::target-text\s*{\s*((.|\n)*?)\s*}/g |
There was a problem hiding this comment.
Does this create a new regex object each time?
| @@ -374,3 +374,17 @@ export function propagateObjectFitStyles(fromEl, toEl) { | |||
| function isVar(property) { | |||
| return property.startsWith('--'); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
nit: add quick description
| } | ||
| const optionElement = new Option(); | ||
| const {style} = optionElement; | ||
| style.color = color.replace('!important', ''); |
There was a problem hiding this comment.
do we need to strip whitespaces?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports the following:
colorandbackground-colorspecified in::target-textruleDoes not support the following:
h1::target-text&p::target-textis not supported. The one specified last will be applied.Fixes #32139.