Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Add minified check to assert #33087

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Conversation

rcebulko
Copy link
Contributor

@rcebulko rcebulko commented Mar 4, 2021

Allows DCE to remove devAssert calls

TODO:

  • verify: gulp dist --core-runtime-only && cat dist/v0.js | grep 'devAssert'
  • figure out how to test more generally to catch this automatically

@rcebulko rcebulko requested a review from jridgewell March 4, 2021 21:25
@amp-owners-bot
Copy link

amp-owners-bot bot commented Mar 4, 2021

Hey @jridgewell! These files were changed:

src/core/assert.js
src/core/minified-mode.js

* limitations under the License.
*/

// Magic constant that is by babel.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: wording.

@lgtm-com
Copy link

lgtm-com bot commented Mar 4, 2021

This pull request introduces 1 alert when merging b345773 into df3c524 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants