Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp-story-player] ✅ Add story attribution visual test #33782

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

Enriqe
Copy link
Contributor

@Enriqe Enriqe commented Apr 12, 2021

Part of #33353

@Enriqe Enriqe force-pushed the story-attribution-visual-diff branch from 81ef855 to fe9ca01 Compare April 14, 2021 19:26
@Enriqe Enriqe requested a review from gmajoulet April 14, 2021 19:56
__AMP_TEST = true;
</script>
<script async src="../../../dist/amp-story-player-v0.js"></script>
<link href="../../../build/css/amp-story-player-v0.css" rel='stylesheet' type='text/css'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: we really really need to fix these URLs so they work like other components :((

@Enriqe Enriqe merged commit 206dcec into ampproject:main Apr 14, 2021
rileyajones pushed a commit to rileyajones/amphtml that referenced this pull request Apr 16, 2021
)

* add story attribution visual test

* viewport size
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
)

* add story attribution visual test

* viewport size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants