Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Extract src/css into core/dom #34036

Merged
merged 10 commits into from
Apr 28, 2021
Merged

♻️ Extract src/css into core/dom #34036

merged 10 commits into from
Apr 28, 2021

Conversation

rcebulko
Copy link
Contributor

Part of #33631

@rcebulko rcebulko marked this pull request as ready for review April 28, 2021 15:33
@amp-owners-bot amp-owners-bot bot requested a review from samouri April 28, 2021 15:33
@amp-owners-bot
Copy link

Hey @erwinmombay! These files were changed:

build-system/eslint-rules/no-import-rename.js

Hey @jridgewell! These files were changed:

build-system/eslint-rules/no-import-rename.js
src/core/dom/css.js

Hey @jeffkaufman! These files were changed:

extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js

Hey @gmajoulet! These files were changed:

extensions/amp-story-dev-tools/0.1/amp-story-dev-tools-tab-preview.js
extensions/amp-story/1.0/amp-story-system-layer.js
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/animation.js
extensions/amp-story/1.0/media-performance-metrics-service.js
extensions/amp-story/1.0/page-advancement.js
extensions/amp-story/1.0/prerender-active-page.js
extensions/amp-story/1.0/progress-bar.js

Hey @mszylkowski! These files were changed:

extensions/amp-story-dev-tools/0.1/amp-story-dev-tools-tab-preview.js

Hey @newmuis, @Enriqe! These files were changed:

extensions/amp-story/1.0/amp-story-system-layer.js
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/animation.js
extensions/amp-story/1.0/media-performance-metrics-service.js
extensions/amp-story/1.0/page-advancement.js
extensions/amp-story/1.0/prerender-active-page.js
extensions/amp-story/1.0/progress-bar.js

@rcebulko rcebulko requested review from jridgewell and removed request for samouri April 28, 2021 15:39
rcebulko
rcebulko commented Apr 28, 2021
View reviewed changes
build-system/tasks/check-types.js
@@ -91,10 +95,6 @@ const TYPE_CHECK_TARGETS = {
srcGlobs: ['src/polyfills{,/**}/*.js'],
warningLevel: 'QUIET',
},
'src-polyfillstub': {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This directory has been merged into src/polyfills

@rcebulko rcebulko merged commit b8ff898 into ampproject:main Apr 28, 2021
@rcebulko rcebulko deleted the core-dom branch April 28, 2021 16:44
@rcebulko rcebulko mentioned this pull request May 10, 2021
Closed
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
@rcebulko @rochapablo
♻️ Extract src/css into core/dom (ampproject#34036)
6dff861 
* Move src/css to src/core/dom (and test)

* Update no-import-rename rule

* Update dep check config

* Move cssEscape helper around

* Update imports from css

* Suppress unreachable code warning for IS_ESM usage

* Fix rebase error

* Remove forbidden terms exception for test file

* Fix css-escape type visibility

* Drop export for assertIsName (only used in dom.js)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@kristoferbaxter kristoferbaxter kristoferbaxter approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rcebulko @kristoferbaxter @jridgewell @ampprojectbot