🏗 Flag an error and exit when Karma runs zero tests #34040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
approved these changes
Apr 27, 2021
jridgewell
approved these changes
Apr 27, 2021
This was referenced Apr 27, 2021
rcebulko
approved these changes
Apr 27, 2021
rsimha
changed the title
rsimha
commented
Apr 27, 2021
rsimha
commented
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in the days of
karma-browserify, a result with zero tests was an occasional transitional condition and wasn't flagged as a fatal error. See #16851 and #24957.Now, with
karma-esbuild, transformation errors can result in zero tests, and it must be flagged as a fatal error. This PR surfaces silent failures like the one in #33418 (comment).A more correct fix would be to get
karma-esbuildto throw an error when it encounters errors like the ones in #34020 (comment).