Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Story Player] Add parameter to configure amp-story-player animation #34204

Merged
merged 13 commits into from
May 11, 2021
Merged

✨ [Story Player] Add parameter to configure amp-story-player animation #34204

merged 13 commits into from
May 11, 2021

Commits on May 4, 2021

  1. added animation options

    @mszylkowski
    mszylkowski committed May 4, 2021
    Configuration menu
    Copy the full SHA
    c3b1494 View commit details
    Browse the repository at this point in the history

  2. Removed animation from behaviordef

    @mszylkowski
    mszylkowski committed May 4, 2021
    Configuration menu
    Copy the full SHA
    b597f79 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. Added newline on player

    @mszylkowski
    mszylkowski committed May 5, 2021
    Configuration menu
    Copy the full SHA
    971c227 View commit details
    Browse the repository at this point in the history

  2. Added documentation on options

    @mszylkowski
    mszylkowski committed May 5, 2021
    Configuration menu
    Copy the full SHA
    9a45074 View commit details
    Browse the repository at this point in the history

  3. Use next to toggle animation

    @mszylkowski
    mszylkowski committed May 5, 2021
    Configuration menu
    Copy the full SHA
    b428926 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Use transitionend

    @mszylkowski
    mszylkowski committed May 6, 2021
    Configuration menu
    Copy the full SHA
    d0e8f66 View commit details
    Browse the repository at this point in the history

  2. Using classes for CSS

    @mszylkowski
    mszylkowski committed May 6, 2021
    Configuration menu
    Copy the full SHA
    8a1a96a View commit details
    Browse the repository at this point in the history

  3. Reverted requestAnimationFrame promise

    @mszylkowski
    mszylkowski committed May 6, 2021
    Configuration menu
    Copy the full SHA
    0b2852f View commit details
    Browse the repository at this point in the history

  4. Added tests

    @mszylkowski
    mszylkowski committed May 6, 2021
    Configuration menu
    Copy the full SHA
    155fabd View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Enrique Marroquin <5449100+Enriqe@users.noreply.github.com>
    @mszylkowski @Enriqe
    mszylkowski and Enriqe authored May 6, 2021
    Configuration menu
    Copy the full SHA
    e76d797 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Use true instead of property 

    Co-authored-by: Enrique Marroquin <5449100+Enriqe@users.noreply.github.com>
    @mszylkowski @Enriqe
    mszylkowski and Enriqe authored May 10, 2021
    Configuration menu
    Copy the full SHA
    f9ba02e View commit details
    Browse the repository at this point in the history

  2. Removed trailing whitespace

    @mszylkowski
    mszylkowski committed May 10, 2021
    Configuration menu
    Copy the full SHA
    6c2ddda View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. Fixed linting

    @mszylkowski
    mszylkowski committed May 11, 2021
    Configuration menu
    Copy the full SHA
    bf4f77b View commit details
    Browse the repository at this point in the history