♻️ Simplify rendering <amp-ima-video> with CSS and static templates #34248
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,211 @@ | ||
| /** | ||
| * Copyright 2021 The AMP HTML Authors. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS-IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /* | ||
| * Styles inserted in iframes rendered by <amp-ima-video>. | ||
| * | ||
| * .selectorsInThisFile reject naming convention by using camelCase rather than | ||
| * dash-case, because they're uniform with Javascript references that are more | ||
| * useful when destructured as such (imaVideo.js). | ||
| * | ||
| * We insert this CSS in a standalone document whose namespace is shared only | ||
| * with the IMA SDK. This unconventional naming is not worth converting to | ||
| * dash-case during build or runtime, so we keep it. | ||
| */ | ||
|
|
||
| [hidden] { | ||
| display: none !important; | ||
| } | ||
|
|
||
| body, | ||
| .video { | ||
| background: black; | ||
| } | ||
|
|
||
| .video { | ||
| width: 100%; | ||
| height: 100%; | ||
| } | ||
|
|
||
| .fill { | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| width: 100%; | ||
| height: 100%; | ||
| } | ||
|
|
||
| button { | ||
| cursor: pointer; | ||
| appearance: none; | ||
| padding: 0; | ||
| border: none; | ||
| background: transparent; | ||
| display: block; | ||
| } | ||
|
|
||
| .controls { | ||
| position: absolute; | ||
| bottom: 0; | ||
| width: 100%; | ||
| background-color: rgba(7, 20, 30, 0.7); | ||
| background: linear-gradient( | ||
| 0, | ||
| rgba(7, 20, 30, 0.7) 0%, | ||
| rgba(7, 20, 30, 0) 100% | ||
| ); | ||
| box-sizing: border-box; | ||
| padding: 10px; | ||
| padding-top: 60px; | ||
| color: white; | ||
| display: flex; | ||
| font-family: Helvetica, Arial, Sans-serif; | ||
| justify-content: center; | ||
| align-items: center; | ||
| user-select: none; | ||
| z-index: 1; | ||
| } | ||
|
|
||
| .controls > *:not(:last-child) { | ||
| margin-right: 20px; | ||
| } | ||
|
|
||
| button > svg { | ||
| width: 100%; | ||
| height: 100%; | ||
| filter: drop-shadow(0 0 14px rgba(0, 0, 0, 0.4)); | ||
| fill: #ffffff; | ||
| } | ||
|
|
||
| .countdownWrapper { | ||
| align-items: center; | ||
| box-sizing: border-box; | ||
| display: none; | ||
| flex-grow: 1; | ||
| font-size: 12px; | ||
| height: 20px; | ||
| overflow: hidden; | ||
| padding: 5px; | ||
| text-shadow: 0 0 10px black; | ||
| white-space: nowrap; | ||
| } | ||
|
|
||
| .time { | ||
| margin-right: 20px; | ||
| text-align: center; | ||
| font-size: 14px; | ||
| text-shadow: 0 0 10px black; | ||
| } | ||
|
|
||
| .progress { | ||
| height: 30px; | ||
| flex-grow: 1; | ||
| position: relative; | ||
| margin-right: 20px; | ||
| } | ||
|
|
||
| .progress::after { | ||
| display: block; | ||
| content: ''; | ||
| background-color: rgba(255, 255, 255, 0.45); | ||
| height: 2px; | ||
| width: 100%; | ||
| margin-top: 14px; | ||
| } | ||
|
|
||
| .progressLine { | ||
| background-color: rgb(255, 255, 255); | ||
| height: 2px; | ||
| margin-top: 14px; | ||
| width: 0%; | ||
| float: left; | ||
| } | ||
|
|
||
| .progressMarker { | ||
| height: 14px; | ||
| width: 14px; | ||
| position: absolute; | ||
| left: 0%; | ||
| top: 50%; | ||
| margin-top: -7px; | ||
| cursor: pointer; | ||
| border-radius: 14px; | ||
| background: white; | ||
| } | ||
|
|
||
| .controls > button { | ||
| width: 30px; | ||
| height: 30px; | ||
| flex-shrink: 0; | ||
| } | ||
|
|
||
| .overlayButton { | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .overlayButton > svg { | ||
| max-width: 120px; | ||
| max-height: 120px; | ||
| } | ||
|
|
||
| /* Swap button's icons based on root state. */ | ||
|
There was a problem hiding this comment. Instead of selecting elements and imperatively |
||
|
|
||
| /* play/pause */ | ||
| .root:not([data-playing]) .playButton > svg:last-child, | ||
| .root[data-playing] .playButton > svg:first-child, | ||
| /* mute/unmute */ | ||
| .root:not([data-muted]) .muteButton > svg:last-child, | ||
| .root[data-muted] .muteButton > svg:first-child { | ||
| display: none; | ||
| } | ||
|
|
||
| /* Ad controls */ | ||
|
|
||
| .root[data-ad] > .controls { | ||
| height: 30px; | ||
| justify-content: flex-end; | ||
| padding: 10px; | ||
| } | ||
|
|
||
| .root[data-ad] > .controls > button { | ||
| height: 22px; | ||
| } | ||
|
|
||
| .root[data-ad] > .controls .muteButton { | ||
| margin-right: 10px; | ||
| } | ||
|
|
||
| @media screen and (max-width: 400) { | ||
|
There was a problem hiding this comment. "Mini" controls are shown when the video is under a certain size an ad is skippable. The latter condition remains in the Javascript logic, while size is just a media query. |
||
| .root[data-skippable] > .controls { | ||
| height: 20px; | ||
| } | ||
| .root[data-skippable] > .controls > button { | ||
| height: 18px; | ||
| } | ||
| } | ||
|
|
||
| /* Show ad controls */ | ||
| .root[data-ad] > .controls > .countdownWrapper { | ||
| display: flex; | ||
| } | ||
|
|
||
| /* Hide non-ad controls */ | ||
| .root[data-ad] > .controls > .time, | ||
| .root[data-ad] > .controls > .progress { | ||
| display: none; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now toggle elements with the
[hidden]attribute. This helps us from knowing how to restore fromdisplay: none, which could be a number of values likeblockorflex.