Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 [bento][npm][amp-twitter] Update npm definition and package file for publishing #34333

Merged
merged 1 commit into from
May 13, 2021
Merged

🏗 [bento][npm][amp-twitter] Update npm definition and package file for publishing #34333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion build-system/compile/bundles.config.extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,15 @@
"cssBinaries": ["amp-truncate-text", "amp-truncate-text-shadow"]
}
},
{"name": "amp-twitter", "version": ["0.1", "1.0"], "latestVersion": "0.1"},
{"name": "amp-twitter", "version": "0.1", "latestVersion": "0.1"},
{
"name": "amp-twitter",
"version": "1.0",
"latestVersion": "0.1",
"options": {
"npm": true
}
},
{
"name": "amp-user-notification",
"version": "0.1",
Expand Down
31 changes: 31 additions & 0 deletions extensions/amp-twitter/1.0/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"name": "@ampproject/amp-twitter",
"version": "VERSION",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this get overwritten by something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The eventual automatic release process. For now, it's manually overwritten before publishing (the workspace doesn't need to be committed to be published).

"description": "AMP Twitter Component",
"author": "The AMP HTML Authors",
"license": "Apache-2.0",
"main": "dist/component.js",
"module": "dist/component.mjs",
"exports": {
".": "./preact",
"./preact": {
"import": "dist/component-preact.mjs",
"require": "dist/component-preact.js"
},
"./react": {
"import": "dist/component-react.mjs",
"require": "dist/component-react.js"
}
},
"files": ["dist/*"],
"repository": {
"type": "git",
"url": "https://github.com/ampproject/amphtml.git",
"directory": "extensions/amp-twitter/1.0"
},
"homepage": "https://github.com/ampproject/amphtml/tree/main/extensions/amp-twitter/1.0",
"peerDependencies": {
"preact": "^10.2.1",
"react": "^17.0.0"
}
}