-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Extract json helpers to core/types/object/json #34367
Conversation
Hey @erwinmombay! These files were changed:
Hey @jridgewell! These files were changed:
Hey @Jiaming-X! These files were changed:
Hey @jeffkaufman! These files were changed:
Hey @alanorozco! These files were changed:
Hey @gmajoulet, @newmuis! These files were changed:
Hey @processprocess! These files were changed:
Hey @Enriqe! These files were changed:
|
@@ -0,0 +1,351 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was moved from test/unit/core/types/test-object.js
@@ -1,5 +1,5 @@ | |||
/** | |||
* Copyright 2015 The AMP HTML Authors. All Rights Reserved. | |||
* Copyright 2021 The AMP HTML Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GH doesn't show this, but this file was moved to src/core/object/types/json.js (which has the 2015 copyright date) and this file is "new"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval for build-system/*
This is the diff to review: 2179341...54ada92
Everything else is just updating import statements.
Part of #32693
Also they pass type-checking now