Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validations for amp-facebook-like:1.0 #35046

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

caroqliu
Copy link
Contributor

@caroqliu caroqliu commented Jun 25, 2021

This PR reverts the amp-facebook-like portion of #34798 following #34969. This does not break any existing valid AMP pages as the original PR is not yet released.

While use of the new 1.0 version of amp-facebook-like will still be valid AMP, its import script will come from the amp-facebook extension. Once amp-facebook-like is registered via AmpFacebook, validations will be updated accordingly. cc @westonruter

@caroqliu caroqliu requested a review from twifkak June 25, 2021 20:16
@amp-owners-bot
Copy link

amp-owners-bot bot commented Jun 25, 2021

Hey @ampproject/wg-caching! These files were changed:

extensions/amp-facebook-like/1.0/test/validator-amp-facebook-like.html
extensions/amp-facebook-like/1.0/test/validator-amp-facebook-like.out
extensions/amp-facebook-like/validator-amp-facebook-like.protoascii

Copy link
Member

@twifkak twifkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @banaag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants