Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Amp story] Add SVG feblend to validation #35436

Merged
merged 2 commits into from
Jul 28, 2021
Merged

🐛 [Amp story] Add SVG feblend to validation #35436

merged 2 commits into from
Jul 28, 2021

Conversation

processprocess
Copy link
Contributor

Adds feblend to amp-story validation.
Updates validation templates.

Fixes #35430

@processprocess processprocess requested a review from gmajoulet July 28, 2021 16:00
@amp-owners-bot
Copy link

amp-owners-bot bot commented Jul 28, 2021 •
edited by ampprojectbot
Loading

Hey @gmajoulet, @newmuis, @ampproject/wg-caching! These files were changed:

extensions/amp-story/1.0/test/validator-amp-story-svg.html
extensions/amp-story/1.0/test/validator-amp-story-svg.out
extensions/amp-story/validator-amp-story.protoascii

@Gregable Gregable mentioned this pull request Jul 28, 2021
Closed
@processprocess processprocess merged commit 09135a9 into ampproject:main Jul 28, 2021
@processprocess processprocess deleted the feblend branch July 28, 2021 22:01
This was referenced Jul 29, 2021
Merged
Closed
@divyarajmasani divyarajmasani mentioned this pull request Aug 25, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

@Gregable Gregable Gregable approved these changes

Assignees
No one assigned
Labels
PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use SVGs with <feBlend> in stories
4 participants
@processprocess @Gregable @gmajoulet @ampprojectbot