Move class-level classes to package-level from Resources #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1070,6 +1036,9 @@ export class Resources { | |||
| task.promise.then(this.taskComplete_.bind(this, task, true), | |||
| this.taskComplete_.bind(this, task, false)) | |||
| .catch(reportError); | |||
| if (task.resource.getState() == ResourceState.LAYOUT_SCHEDULED) { | |||
There was a problem hiding this comment.
Where'd this come from?
There was a problem hiding this comment.
It was done in the Resource class by calling internal Resources state. So, I decided to move it here - it's the same signal, just less leaking of Resources vars.
|
LGTM. |
|
MERGE MERGE MERGE! Glad this is finally happening! |
This was referenced Jul 16, 2020
This was referenced Dec 30, 2020
This was referenced Mar 4, 2021
This was referenced Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No real refactoring here yet: just moved
Resource,TaskQueueandfixIeMediaBugto separate modules and the same is done for tests.