♻️ Bento: Internal components should not need ...rest

[caroqliu]

... because we know exactly what props are being passed to it, and should propagate them intentionally when relevant rather than blindly.

That's how we get the outsetArrows issue described in #35553:

* Warning: React does not recognize the `outsetArrows` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `outsetarrows` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

The internal components targeted include:

• BaseCarousel's helpers Scroller, Arrow, and DefaultArrow
• StreamGallery's helper DefaultArrow
• LightboxGalleryProviders's helpers CloseButtonIcon, NavButtonIcon, and ToggleViewIcon
• Lightbox's helper ScreenReaderCloseButton
• SocialShare's helper SocialShareIcon

/to @developit

[amp-owners-bot]

Hey @erwinmombay, @jridgewell! These files were changed:

build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/index.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep-array/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep-array/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/deep/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/param/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/param/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/skip-element/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/skip-element/options.json
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/skip-element/output.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/variable-declarations/input.js
build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/test/fixtures/transform/variable-declarations/options.json
+3 more

[developit]

Looks good! Does Bento have any sort of memory tracking/benchmarking set up? I would expect this to show a decent reduction in memory footprint due to the reduced cloning.

[alanorozco]

Thanks!

[caroqliu]

Does Bento have any sort of memory tracking/benchmarking set up?

Good idea, no memory tracking/benchmarking set up currently, but I'll make a note to look into this. Thanks.