Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtensionSpec with bento_supported_version #35757

Merged
merged 2 commits into from
Aug 20, 2021
Merged

ExtensionSpec with bento_supported_version #35757

merged 2 commits into from
Aug 20, 2021

Conversation

honeybadgerdontcare
Copy link
Contributor

Fixes #35756

@honeybadgerdontcare honeybadgerdontcare marked this pull request as ready for review August 20, 2021 19:43
@amp-owners-bot
Copy link

amp-owners-bot bot commented Aug 20, 2021 •
edited by ampprojectbot
Loading

Hey @ampproject/wg-amp4email! These files were changed:

extensions/amp-accordion/validator-amp-accordion.protoascii
extensions/amp-fit-text/validator-amp-fit-text.protoascii
extensions/amp-lightbox/validator-amp-lightbox.protoascii
extensions/amp-selector/validator-amp-selector.protoascii
extensions/amp-timeago/validator-amp-timeago.protoascii

Hey @ampproject/wg-caching! These files were changed:

extensions/amp-accordion/validator-amp-accordion.protoascii
extensions/amp-base-carousel/validator-amp-base-carousel.protoascii
extensions/amp-brightcove/validator-amp-brightcove.protoascii
extensions/amp-date-countdown/validator-amp-date-countdown.protoascii
extensions/amp-date-display/validator-amp-date-display.protoascii
extensions/amp-embedly-card/validator-amp-embedly-card.protoascii
extensions/amp-facebook/validator-amp-facebook.protoascii
extensions/amp-fit-text/validator-amp-fit-text.protoascii
extensions/amp-inline-gallery/validator-amp-inline-gallery.protoascii
extensions/amp-instagram/validator-amp-instagram.protoascii
extensions/amp-lightbox-gallery/validator-amp-lightbox-gallery.protoascii
extensions/amp-lightbox/validator-amp-lightbox.protoascii
+14 more

Hey @westonruter, @ediamin! These files were changed:

extensions/amp-wordpress-embed/validator-amp-wordpress-embed.protoascii

@honeybadgerdontcare honeybadgerdontcare merged commit 976b827 into main Aug 20, 2021
caroqliu
caroqliu reviewed Aug 20, 2021
View reviewed changes
extensions/amp-wordpress-embed/validator-amp-wordpress-embed.protoascii
@@ -5,6 +5,7 @@ tags: { # amp-wordpress-embed
name: "amp-wordpress-embed"
version: "1.0"
version: "latest"
bento_supported_version: "1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one includes latest, since 1.0 is the only version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #35762

extensions/amp-stream-gallery/validator-amp-stream-gallery.protoascii
@@ -5,6 +5,7 @@ tags: { # amp-stream-gallery
name: "amp-stream-gallery"
version: "1.0"
version: "latest"
bento_supported_version: "1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one includes latest, since 1.0 is the only valid version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #35762

@rsimha rsimha deleted the bento-supported-version branch August 27, 2021 16:31
@westonruter westonruter mentioned this pull request Nov 8, 2021
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelRybak MichaelRybak MichaelRybak approved these changes

@caroqliu caroqliu Awaiting requested review from caroqliu

@westonruter westonruter Awaiting requested review from westonruter

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: bento WG: caching
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indicate bento supported versions within ExtensionSpec
4 participants
@honeybadgerdontcare @MichaelRybak @caroqliu @ampprojectbot