Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Hide placeholder when tweet loads successfully #35788

Merged
merged 1 commit into from
Aug 25, 2021
Merged

🐛 Hide placeholder when tweet loads successfully #35788

merged 1 commit into from
Aug 25, 2021

Conversation

kvchari
Copy link
Contributor

@kvchari kvchari commented Aug 24, 2021

fixes #34616

@amp-owners-bot
Copy link

amp-owners-bot bot commented Aug 24, 2021 •
edited by ampprojectbot
Loading

Hey @ampproject/wg-performance! These files were changed:

tsconfig.json

@kvchari kvchari marked this pull request as draft August 24, 2021 19:34
rcebulko
rcebulko reviewed Aug 24, 2021
View reviewed changes
Copy link
Contributor

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR contain the tsconfig.json changes?

extensions/amp-twitter/1.0/component.js Outdated Show resolved Hide resolved
@kvchari kvchari force-pushed the hide-placeholder-bento-twitter branch 2 times, most recently from d5cb966 to 96165e7 Compare August 24, 2021 19:46
@kvchari
Copy link
Contributor Author

kvchari commented Aug 24, 2021

@rcebulko rebased to drop the tsconfig commits

@kvchari kvchari force-pushed the hide-placeholder-bento-twitter branch from 96165e7 to 98b3f8a Compare August 24, 2021 20:12
@kvchari
Copy link
Contributor Author

kvchari commented Aug 24, 2021

removed the @types/enzyme dependency i added because multiple typings for react end up getting installed causing type errors (https://app.circleci.com/pipelines/github/ampproject/amphtml/15289/workflows/bf7a8dd0-de3b-49bd-a077-05f45325ed02/jobs/264732). resolving to 1 version would solve this, but is out of scope for this

@kvchari kvchari marked this pull request as ready for review August 24, 2021 20:30
caroqliu
caroqliu requested changes Aug 24, 2021
View reviewed changes
extensions/amp-twitter/1.0/component.js Outdated
@@ -27,6 +27,7 @@ function TwitterWithRef(
timelineSourceType,
timelineUserId,
title,
togglePlaceholder,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this approach works, the concept of a placeholder is somewhat specific to AMP, and we don't need to be as prescriptive as to assume that an author wants to implement the component this way.

I'd recommend that the Preact layer have a more generic prop, such as onLoad and onError, which are called at appropriate lifecycle states -- perhaps onLoad once the height is received and onError when receiving a NO_CONTENT message like in 0.1. And then the AMP layer would pass the placeholder accordingly:

// amp-twitter.js
onError: () => this.togglePlaceholder(true),
onLoad: () => this.togglePlaceholder(false)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this approach better - updated to use do that

@kvchari kvchari force-pushed the hide-placeholder-bento-twitter branch 3 times, most recently from 1d008ce to fb9d428 Compare August 25, 2021 14:59
@kvchari kvchari force-pushed the hide-placeholder-bento-twitter branch from fb9d428 to 6a33a55 Compare August 25, 2021 15:02
@kristoferbaxter
Copy link
Contributor

Congrats on first merge!

@kristoferbaxter kristoferbaxter merged commit 9151bde into ampproject:main Aug 25, 2021
@westonruter westonruter mentioned this pull request Aug 25, 2021
Closed
westonruter
westonruter reviewed Aug 25, 2021
View reviewed changes
extensions/amp-twitter/1.0/amp-twitter.js
Comment on lines +61 to +62
'onLoad': () => this.togglePlaceholder(false),
'onError': () => this.togglePlaceholder(true),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these have actually gone into BaseElement perhaps? I'm realizing that the issue was not unique to amp-twitter. The amp-youtube component also has this issue, for example: #34616 (comment).

@kvchari kvchari mentioned this pull request Aug 26, 2021
Merged
@kvchari kvchari deleted the hide-placeholder-bento-twitter branch August 26, 2021 13:54
DevMahix pushed a commit to BroadBandyDev/amphtml that referenced this pull request Sep 9, 2021
@kvchari
hide placeholder when tweet is succesfully loaded (ampproject#35788)
1f9792e
DevMahix pushed a commit to BroadBandyDev/amphtml that referenced this pull request Sep 9, 2021
@kvchari
hide placeholder when tweet is succesfully loaded (ampproject#35788)
0192b92
powerivq added a commit that referenced this pull request Sep 16, 2021
@BroadBandyDev @tverbert
@DevMahix @kvchari @caroqliu @samouri @mmmicedcoffee @rsimha @kristoferbaxter @oath-jac @processprocess @jridgewell @dmanek @powerivq @ColombiaOnline @estherkim @rileyajones @anrghg @ishaba @renovate @alanorozco @MichaelRybak @honeybadgerdontcare @rbeckthomas @zombifier @danielrozenberg @bretg @ChrisAntaki @mszylkowski @jshamble @klipstein @coreymasanto @gmajoulet @PetrBlaha @zhangsu @golovatuy @hartmannr76 @antiphoton
Broadbandy AMP Integration (#36010)
51b3485 
* Broadbandy ad service implementation

* Revert serve port

* Broadbandy ad service implementation

* Revert serve port

* 🏗 Misc tsconfig updates (#35787)

* update compilerOptions.paths to handle barrel files (index.js) in VSCode

* update includes/excludes allowlist/blocklist src files

* ♻️ Bento Selector: Simplify logic (#35758)

* Bento Selector Option: Give props via JSX

* Remove extraneous event handlers

* esbuild-exp fix define_experiment_constant (#35800)

* SwG Release 0.1.22.181 (#35808)

* Improve AMP_CONFIG handling during build (#35773)

* applyAmpConfig: also update sourcemaps

* no stone unturned: AMP_CONFIG should be part of the wrapper

* update comments

* update comment + fix bug

* another bugfix

* allow newline between ; and AMP_CONFIG

* retain logs for dist|build

* smol clean

* Update build-system/tasks/prepend-global/index.js

Co-authored-by: Raghu Simha <rsimha@amp.dev>

* Update build-system/tasks/prepend-global/index.js

Co-authored-by: Raghu Simha <rsimha@amp.dev>

* target --> filename

Co-authored-by: Raghu Simha <rsimha@amp.dev>

* hide placeholder when tweet is succesfully loaded (#35788)

* 🚮 Remove IE Support via Polyfills and Conditional Statements (#35317)

* Since we are not using the data, lets remove it

* Remove all isIE checks and polyfills only used by IE

* Remove URL changes

* Integration tests were looking for IE specifics

* remove transparent img, and ie tests

* Skip all tests on IE, this functionality will be removed by the infra team following success

* try using user agent directy in test configuration

* Fix

* Feedback on describe tests not needing configuration now

* Remove unused files again

* Fix build before main is repaired

* 🏗🚮 Remove all IE11 infrastructure code paths (#35341)

* Revert "Improve AMP_CONFIG handling during build (#35773)" (#35819)

* ♻️ Verizon media yahoo components merge (#35797)

* Merged the VerizonMedia ad component into the yahoo component

* Fixed documentation formatting issues.

* 🐛 [Amp story] Catch ScreenOrientation.lock promise (#35767)

* Catch for promise.

* Update comment.

* Send e.

* 🐛[Amp story] Add position scope to attachment-content wrapper (#35786)

* Add position to attachment-content wrapper.

* whitespace

* remove re-export and update MessageType imports (#35817)

* Wrap all play calls in catch handler (#35811)

* Wrap all play calls in catch handler

* Introduce playIgnoringError

* Fix type

* Fix undefined return case

* [amp-iframe] Wrap iframe in shadow DOM and ContainWrapper (#35774)

* build-system: fix infinite loop caused by watching css in npm dist folders. (#35827)

* Change amp-sticky-ad-to-amp-ad name to avoid trigging the old experiment unintentionally (#35779)

* amp GAM support added (#35782)

* add policy attributes

* add owners

* update files for Owners.

* Revert file

* added GAM implementation

* removed policy attribute

* removed policy attribute description

* changed attribute name and corrected indentation

* indentation corrected

* new line added at last

* 🏗  Simplify release tracker issue template (#35825)

* update

* more

* .

* fix some types (#35832)

* ie deprecation/bugfix: remove isIe check (#35833)

* Disable EsbuildCompilation experiment. (#35814)

* ✨ Action `toggleChecked()` (#35795)

* Update amp-actions-and-events.md

* Update amp-email-actions-and-events.md

* Update standard-actions.amp.html

* Update scroll-component.js

* Update action-impl.js

* Update standard-actions-impl.js

* Update test-action.js

* Update test-standard-actions.js

* Update test-standard-actions.js

* Update amp-actions-and-events.md

* Update amp-email-actions-and-events.md

* Update standard-actions.amp.html

* Update scroll-component.js

* Update action-impl.js

* Update standard-actions-impl.js

* Update test-action.js

* Update test-standard-actions.js

* Fix error  Delete `⏎`  prettier/prettier

* Update amp-actions-and-events.md

* Update amp-email-actions-and-events.md

* Update standard-actions.amp.html

* revert for attribution

* revert for attribution

* revert for attribution

* Update docs/spec/amp-actions-and-events.md

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

* Update docs/spec/amp-email-actions-and-events.md

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

* Update examples/standard-actions.amp.html

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

* Update test-standard-actions.js

* Update test-standard-actions.js

* Update test-standard-actions.js

* Fix error  Insert `,`  prettier/prettier

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

* Add TrafficStars ad network support (#35836)

* 📦 Update dependency esbuild to v0.12.11 (#35058)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* 📦 Update dependency prettier to v2.3.2 (#35059)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* 📦 Update dependency esbuild to v0.12.24 (#35840)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* ✨ `amp-date-display`: Support `timeZoneName` and `timeZoneNameShort` (#35828)

Fixes #35812

Adds support for template variables `{{timeZoneName}}` and `{{timeZoneNameShort}}`.

Added to Classic (`0.1`) and Bento (`1.0`) versions.

* 📦 Update dependency prismjs to 1.24.0 [SECURITY] (#35082)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* 📦 Update dependency path-parse to 1.0.7 [SECURITY] (#35600)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* 📦 Update linting devDependencies (#35842)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* 📦 Update subpackage devDependencies (#35035)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* 📦 Update dependency eslint-plugin-jsdoc to v36 (#35392)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* 📦 Update core devDependencies (#34748)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* 📦 Update validator devDependencies (#35841)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* 📦 Update build-system devDependencies (major) (#35377)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* 📦 Update dependency jszip to 3.7.0 [SECURITY] (#35599)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* 📦 Update build-system devDependencies (#34993)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* Remove amp-unresolved when extension downloads in R1 (#35845)

* Remove amp-unresolved when extension downloads in R1

* test

* Lint

* 🏗 Ensure every babel invocation has a name (#35851)

* 🏗 Replace `globby` with `fast-glob` (#35846)

* Remove IE11 support from supported browsers (#35865)

* mode: collapse definitions of localDev and test (#35823)

* mode: collapse localDev and test

* fix tests

* video-iframe-integration: test agnosticism.

* bring back isProd for DCE

* remove isLocalDev from core/mode

* getMode override --> AMP_CONFIG override.

* Remove getIntersectionChangeElementLayoutBox from amp-iframe. (#35860)

* Find sizer and apply slot before `layoutCallback` (#35784)

* Apply sizer slot in `buildInternal`

* Use optional chain in `applyStaticLayout`

* 📖 `bento-twitter` documentation (#35847)

* Copy to 0.1 subdir

* Edit existing documentation

* Create readme

* 🖍 Fix displaying hero images over blurry image placeholder (#35759)

* Fix displaying hero images over blurry image placeholder

This is a second attempt at fixing #32387. The first attempt improperly used `.i-amphtml-ssr` (a class selector), when it should have been `[i-amphtml-ssr]` (a property selector).

* Update z-index doc

* 🐛 [Amp story page attachment] Propagate title attribute to draggable drawer header (#35863)

* Propogate title attribute to header.

* Only build title element if title is defined.

* Validator rollup (#35882)

* cl/392962279 Allow style in noscript.

* cl/393187930 Make no-js case valid.

* cl/393885470 Remove notice from CSS/Doc length tests.

Co-authored-by: Greg Grothaus <greggrothaus@google.com>
Co-authored-by: honeybadgerdontcare <sedano@google.com>

* Remove "for the specified Twitter id" (#35887)

* Sync for validator cpp engine and cpp htmlparser (#35885)

* Make no-js case valid. The basic structure of the change is to set up a series of requires/satisfies pairs:
- Extension js requires v0.js (this is the only code change).
- amp-pixel, amp-img, and amp-layout, which have no extension js, likewise require v0.js
- non-transformed v0.js requires style boilerplate and the noscript variant (transformed does not).

Then we remove the mandatory bits on all of these tags. They are no longer globally mandatory, they are only conditionally mandatory.

PiperOrigin-RevId: 393187930

* Remove notice for CSS/Doc length tests.

PiperOrigin-RevId: 393885470

Co-authored-by: Greg Grothaus <greggrothaus@google.com>
Co-authored-by: honeybadgerdontcare <sedano@google.com>

* Make `compiler.js` runnable within a node.js environment (#35849)

* 🐛[`amp-tiktok`] Fix CLS bug.  (#35850)

* [`amp-tiktok`] Fix CLS issue caused by promise failing to resolve.

* [`amp-tiktok`] Add Tests for CLS fix.

* [`amp-tiktok`] Update unit tests to cover cls fix case.

* [`amp-tiktok`] Remove trailing whitespaces.

* ♻️ Remove use of `.find` (#35884)

- Fixes compatibility in old browsers that don't support `.find()`
- Fixes ampproject/error-reporting#103

* 📦 Update build-system devDependencies (#35856)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* 📦 Update dependency eslint-plugin-react to v7.25.1 (#35858)

Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>

* Skip new test failures after Chrome93 release (#35900)

* 🐛 Use `/register` for Storybook addons (#35890)

Preact environment had been updated to this module path, but the AMP environment had not.

* ⏮ Rollback `timeZoneName` changes (#35895)

For cherry-pick #35892

* Fix child identifiers in Doubleclick SRA IUs. (#35891)

* 🏗 Cut a new nightly branch using CircleCI's scheduled jobs (dry run) (#35878)

* RTC vendors: add ConsentMetadata to Prebid Server (#33899)

Adding gdpr_applies, consent_type, and addtl_consent to Rubicon and AppNexus Prebid Server RTC strings as followup to #30006.

Adding @SyntaxNode as FYI for AppNexus.

* Revert "⏮ Rollback `timeZoneName` changes (#35895)" (#35911)

This reverts commit 017c5a8.

* 🏗 Alias `amp-*.js` binaries as `bento-*.js` (#35880)

`amp-*.js` binaries for Bento-compatible extensions provide an `<amp-*>` element that can be used **with** `v0.js`, and a `<bento-*>` element that can be used **without** `v0.js`.

We'd like that Bento elements are used from `bento-*.js` in Bento mode. This unblocks release since we'll be able to include the scripts in Bento mode using the correct URL.

Eventually, this binary will only provide the Bento element, while `amp-*.js` will provide only an AMP element. In the meantime, we alias the multiple-compatibility binary so that `bento-*.js` can be used as soon as possible.

* SwG Release 0.1.22.182 (#35919)

* Revert "mode: collapse definitions of localDev and test (#35823)" (#35918)

This reverts commit 59a07a3.

* ♻️ [Story performance] Simplify templates CSS by using attr instead of class (#35861)

* Changed classes for template attr

* Simplified rules

* Fixed some comments

* Remove unused template

* Reverted pan demo to image

* Removed unused const

* Added CTA Migration page-outlink experiment (#35867)

* Added CTA Migration page-outlink experiment, added logic to have it load during the Promise chain in the layout callback

* fixed some circleCI errors

* fixed some nits

* refactored cta migration and added non-hardcoded values

* fixed cricleci spacing issues

* fixed cricleci spacing issues

* Added description and re-comtting due to circleCI

* Added description and re-comtting due to circleCI

* Fixed more code review nits

* Fixed layout callback unit test

* Added back in code-breaking refactor

* will open new PR to fix page-attachment prod bug

* fixed main merge

* renamed the expirement to make it clear it was associated with ads

* 🐛 Toggle placeholders/fallbacks properly on Bento components (#35821)

* create centralized hooks for onLoad/onLoading/onError in PreactBaseElement

* update instances where components used their own (similar) hooks

* toggle placeholders for bento components with dynamic content

* update storybook stories to demonstrate placeholders/fallbacks
* update closure typings
* update docs

* Move nightly branch cut job from CircleCI to GitHub Actions (#35909)

* 🐛 [amp-video-docking] Fix issue hiding docked player during scroll on mobile (#35839)

Test-Case:

- Start via `amp --extensions=amp-video-iframe,amp-video-docking`
- Open http://localhost:8000/examples/article-with-docked-video.html with the iOS simulator
- Play first video in article
- Scroll down so that the player is docked
- Now scroll further down and then quickly up so that the URL bar is shown again
- Result => dock gets hidden

This pull request fixes the problem by only checking whether the width changed on resize to decide whether the player should be undocked.

Also see this comment, which also explains the bug: #27825 (comment)

cc @alanorozco

* Skip flaky test (#35926)

* ♻️ Use Storybook `args` (first round) (#35915)

Partial for #35923

This is the first step to replace Storybook Knobs (deprecated)[1] with Controls[2].

[1] https://www.npmjs.com/package/@storybook/addon-knobs
[2] https://storybook.js.org/docs/react/essentials/controls

We have over 60 Storybook files. I'm submitting the PRs in multiple rounds to prevent overwhelming the reviewers.

In summary:

1. Installs `@storybook/addon-controls`
2. Updates template for generated Stories.
3. Updates 15 Stories across extensions.

* 🐛 [Amp story page outlink] Default outlink color and warning (#35866)

* Default outlink color.

* Remove unnecessary if block.

* 🐛 [Amp story] Prevent pointer events on images (#35929)

* Prevent pointer events on images.

* Update comment.

* Select images in grid layer.

* cl/394490119 Fix a bug where the CSS parser was not correctly accounting for the possibility of calc() in the media expression. (#35937)

* 🏗 Visual diff updates and fixes (#35942)

* Update visual diff's Chrome version to 91.0.4472.0

* Remove page-preparation snippets that are now included in Percy's serializer library

* :%s/.percyCss/.percyCSS/

* Remove <noscript> elements from doc/iframes

* Restore <canvas> → <img> freezer

* Bento Carousel: Restore default `rtl` values (#35924)

* 🐛 [Attachment Forms] Remove the soft keyboard from view when the page attachment is closed (#35798)

* Remove focus from elements when closing the page attachment

* Hide page attachments when the window has resized and the drawer is closed

* Prettier

* Adding local files for testing

* Rename unfocusChildElements_() to dismissSoftKeyboard_()

* Reset the story's scroll position instead of hiding the attachment

* Prettier

* Remove demo files

* Add back demo example files for testing

* Rename dismissSoftKeyboard_ to blurFocusedEl_ and clarify keyboard-related comments

* Simplify the demo

* Fold the attachment-forms.html examples into the existing attachment.html example file

* Update the ID of the second example

* Update blur the active element instead of using a query selector

* Set the demo's paragraph font size so that the text doesn't resize when the soft keyboard opens

* Add a visual test to confirm that the soft keyboard closes along with attachment close

* Add missing comma

* Remove trailing whitespace

* Comment updates; removed new paragraph element to dismiss the attachment by tapping the spacer instead

* Use p element again in the visual diff test, since the spacer element is not visible on desktop

* Use .i-amphtml-story-page-attachment-close-button to dismiss the attachment instead of a p element

* Move the form presence visual tests to be adjacent to each other

* Remove publisher domain text within the form presence visual diff tests

* Formatting fixes

* Formatting fixes

* Use a dummy domain name instead of removing it altogether

* Rename `BaseCarousel` as `BentoBaseCarousel` (#35935)

* Rename `Twitter` to `BentoTwitter` (#35933)

* 📖 Update Storybook documentation in `testing.md` (#35944)

Listed commands were outdated. Added some more detail and changed some phrasing.

* 📖 [Story videos] Add video documentation for Google cache (#35609)

* Add video documentation

* More detail

* Added section on amp-story

* Update extensions/amp-story/amp-story.md

Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>

* Updating documentation with approved language

* Simplify amp-story.md

Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>

* Update release-tagger.yml (#35946)

* Add TrafficStars ad network integration (#35922)

* Add trafficstars ad network integration

* Remove integration from 3p

* Sync for validator cpp engine and cpp htmlparser (#35952)

* Fix a bug where the CSS parser was not correctly accounting for the possibility
of calc() in the media expression.

PiperOrigin-RevId: 394490119

* Remove .proto.h from parse-css.cc imports. The .pb.h version works with bazel.

PiperOrigin-RevId: 394774272

* ✨ Ssp params extended  (#35957)

Co-authored-by: PetrBlaha <petr.blaha@firma.seznam.cz>

* refactor(amp-accordion): (#35864)

* update (p)react component names
* update component.type

* * rename DateDisplay -> BentoDateDisplay (#35875)

* rename component.type
* ensure css is published

* 🐛 Followup fix from BaseCarousel → BentoBaseCarousel rename (#35968)

* rename `Instagram` to `BentoInstagram` (#35949)

* BentoFitText title to 'FitText' (#35972)

* 🏗 Parallelize `dist` steps (#35943)

* 📖 BentoBaseCarousel README code fixes (#35973)

* 🏗  Fix `make release` bug for release tagger (#35947)

* get ref instead of release

* release note tweaks

* * rename InlineGallery -> BentoInlineGallery (#35876)

* rename Pagination -> BentoInlineGalleryPagination
* rename Thumbnails -> BentoInlineGalleryThumbnails
* update component.type

* * rename DateCountdown -> BentoDateCountdown (#35874)

* update component.type
* ensure css is published

* refactor(amp-stream-gallery): rename StreamGallery -> BentoStreamGallery (#35879)

* Update Storybook template to differentiate between `Foo` and `BentoFoo` (#35974)

* Update Storybook template

* Set prefix in code, not template replacememt

* Set experiment to 1 (#35970)

* Clean up some small linter issues with validator files. (#35982)

* Rename `Instagram` to `BentoInstagram` (#35948)

* Rename EmbedlyCard -> BentoEmbedlyCard (#35977)

* Make amp-form failure message developer-friendlier (#35964)

This can happen whenever the XHR proxy server returns an error and
doesn't include the HTML to render the submit-failure template (e.g.,
AMP CORS failure, unreacheable proxy). Sever-side rendering of template
is an implementation detail of AMP for Email that developers shouldn't
care about so it makes sense to change this to one that would make more
sense for developers.

* added refresh interval for amp-ad blocks in the apester-media (#35961)

🐛 Bug fix. 1) Added refresh interval for amp-ad blocks in the amp-apester-media 2) Moved inline styles into class for amp-apester-media bottom ad block with the fix of centering this block.

* 📖 Warn when using a consent promptUI that contains an iframe (#35986)

Because of the rendering cycle, a `promptUI` that contains an `amp-iframe` may cause content flashing.

`promptUISrc` can be used instead and prevent that issue.

* ♻️ Use Storybook `args` (second round) (#35930)

Partial for #35923

* 📖  Add Storybook Style Recommendations (#35945)

* 🖍  [Attachment Forms] Update the style of the attachment header text (#35862)

* Make the publisher domain text lighter than the attachment's title text

* Uncomment out changes

* Increase the size of the attachment's title font

* Make the attachment title and domain URL bolder, and decrease the distance between them

* Place the domain label above the title so that the title doesn't conceal part of the domain

* Increase bottom padding of header to ensure domain label doesn't overlap attachment content

* 🏗 Update Storybook forbidden terms (#35991)

1. Move `withA11y` entry to `forbiddenTermsGlobal`. It wasn't targetting the right files previously.

2. Add `@storybook/addon-knobs` since it's deprecated.

Partial for #35923

* SwG Release 0.1.22.183 (#35997)

* ♻️ Rename `Brightcove` to `BentoBrightcove` (#35994)

* Pin CircleCI's Chrome version (#35916)

This is to prevent new stable releases of Chrome from causing test failures. Eg, the Chrome 93 release caused several tests failures that made `main` red until the tests were skipped. This delayed a cherry-pick we're working on, since the new release (on on top of old code) also picked up Chrome 93.

This should be updated regularly, hopefully with a chance to test Chrome releases during the Beta period so we can proactively fix issues.

Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev>

* ♻️ Provide BentoVideo (#35993)

* ♻️ Rename `Vimeo` to `BentoVimeo` (#35995)

* ♻️ Rename `Youtube` to `BentoYoutube` (#35996)

* 🐛 [Story animations] Fix prerender resume animation (#35987)

* Add try catch

* Changed PR number to match PR

* 🏗 Enable `npm` for `amp-video` (#34819)

* 📖 Add instructions to reproduce validator tests (#35980)

* remove editor ignore file

* revert register integration

* remove unused import

* change import order

* prettify code

Co-authored-by: Mahir <mahir@techwave.io>
Co-authored-by: tijl verbert <tijl.verbert@gmail.com>
Co-authored-by: DevMahix <mahir_b@msn.com>
Co-authored-by: Keshav Varadachari <keshavvi@google.com>
Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com>
Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
Co-authored-by: mmmicedcoffee <1164097+mmmicedcoffee@users.noreply.github.com>
Co-authored-by: Raghu Simha <rsimha@amp.dev>
Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>
Co-authored-by: oath-jac <45564796+oath-jac@users.noreply.github.com>
Co-authored-by: Philip Bell <philip.hunter.bell@gmail.com>
Co-authored-by: Justin Ridgewell <jridgewell@google.com>
Co-authored-by: dmanek <506183+dmanek@users.noreply.github.com>
Co-authored-by: Shihua Zheng <powerivq@users.noreply.github.com>
Co-authored-by: ColombiaOnline <sandeep.saini1@timesinternet.in>
Co-authored-by: Esther Kim <44627152+estherkim@users.noreply.github.com>
Co-authored-by: Riley Jones <78179109+rileyajones@users.noreply.github.com>
Co-authored-by: anrghg <88852183+anrghg@users.noreply.github.com>
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Co-authored-by: Ilya Shabanov <ishaba@me.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com>
Co-authored-by: Michael Rybak <michaelrybak@google.com>
Co-authored-by: Greg Grothaus <greggrothaus@google.com>
Co-authored-by: honeybadgerdontcare <sedano@google.com>
Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com>
Co-authored-by: Khoi Doan <khoid@google.com>
Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev>
Co-authored-by: bretg <bgorsline@gmail.com>
Co-authored-by: Chris Antaki <ChrisAntaki@gmail.com>
Co-authored-by: Matias Szylkowski <mszylkowski@google.com>
Co-authored-by: Jonathan <jshamble@users.noreply.github.com>
Co-authored-by: Tobias von Klipstein <tobias@klpstn.com>
Co-authored-by: Corey Masanto <masanto@google.com>
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
Co-authored-by: PetrBlaha <petrblahamail@gmail.com>
Co-authored-by: PetrBlaha <petr.blaha@firma.seznam.cz>
Co-authored-by: Su Zhang (張甦) <me@zhang.su>
Co-authored-by: Oleksandr Golovatyi <golovatuy@gmail.com>
Co-authored-by: Ricky Hartmann <hartmannr76@gmail.com>
Co-authored-by: Boxiao Cao <9083193+antiphoton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcebulko rcebulko rcebulko left review comments

@westonruter westonruter westonruter left review comments

@caroqliu caroqliu caroqliu approved these changes

@kristoferbaxter kristoferbaxter Awaiting requested review from kristoferbaxter

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bento: components fail to hide placeholder content once loaded
6 participants
@kvchari @kristoferbaxter @westonruter @rcebulko @caroqliu @ampprojectbot