Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validator amp-ad test output #36281

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Update validator amp-ad test output #36281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions extensions/amp-ad/0.1/test/validator-amp-ad.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,14 @@ amp-ad/0.1/test/validator-amp-ad.html:63:2 The attribute 'height' in tag 'amp-ad
| <!-- Invalid: amp-ad type=custom missing data-url-->
| <amp-ad width=300 height=250
>> ^~~~~~~~~
amp-ad/0.1/test/validator-amp-ad.html:65:2 The mandatory attribute 'data-url' is missing in tag 'amp-ad'. (see https://github.com/ampproject/amphtml/blob/main/ads/custom.md)
amp-ad/0.1/test/validator-amp-ad.html:65:2 The mandatory attribute 'data-url' is missing in tag 'amp-ad'. (see https://github.com/ampproject/amphtml/blob/main/ads/vendors/custom.md)
| type="custom"
| template="template-1">
| </amp-ad>
| <!-- Invalid: amp-ad type=custom non-https data-url-->
| <amp-ad width=300 height=250
>> ^~~~~~~~~
amp-ad/0.1/test/validator-amp-ad.html:70:2 Invalid URL protocol 'http:' for attribute 'data-url' in tag 'amp-ad'. (see https://github.com/ampproject/amphtml/blob/main/ads/custom.md)
amp-ad/0.1/test/validator-amp-ad.html:70:2 Invalid URL protocol 'http:' for attribute 'data-url' in tag 'amp-ad'. (see https://github.com/ampproject/amphtml/blob/main/ads/vendors/custom.md)
| type="custom"
| data-url="http://foobar.com"
| template="template-1">
Expand All @@ -90,4 +90,4 @@ amp-ad/0.1/test/validator-amp-ad.html:76:2 The attribute 'sticky' in tag 'amp-ad
| data-aax_src="302">
| </amp-ad>
| </body>
| </html>
| </html>