src/core/function: grab Date off win #37225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
force-pushed
the
fix-win-date
branch
from
58e2d5f
to
2a66bca
Compare
|
Hey @jridgewell! These files were changed: |
alanorozco
reviewed
Dec 15, 2021
| interface Window { | ||
| Date: typeof Date; | ||
| } | ||
| } |
There was a problem hiding this comment.
Should this be in this directory? Could it be scoped to the root dir?
There was a problem hiding this comment.
@rcebulko and I are in the middle of bike-shedding what to do about the Window globals. Since he's out I followed the pattern he started (of scoping as closely as possible).
My preference would be to group together all of the builtin mappings from global into Window in a single window.d.ts file.
There was a problem hiding this comment.
I think you're right, my approach made more sense when using reference tag but since we can't we may as well combine
alanorozco
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Fixes a small bug that should only affect tests introduced in #37141.
TODO
Why didn't CI fail for the problem PR