Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force amp sticky ad layout and move scroll listener to earlier stage #37456

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Force amp sticky ad layout and move scroll listener to earlier stage #37456

merged 1 commit into from
Jan 29, 2022

Conversation

powerivq
Copy link
Contributor

Performance enhancement for sticky ads:

  1. Force layout to address scenarios where the size is 0x0 and layout is not triggered.
  2. Setup scroll callback earlier to catch more scrolls.

@powerivq powerivq force-pushed the perf-ticky branch 2 times, most recently from 971377d to e6dade5 Compare January 24, 2022 06:23
@powerivq powerivq merged commit ccf1f0f into ampproject:main Jan 29, 2022
@powerivq powerivq deleted the perf-ticky branch January 29, 2022 09:08
samouri pushed a commit to samouri/amphtml that referenced this pull request Feb 2, 2022
@powerivq @samouri
Force amp sticky ad layout and move scroll listener to earlier stage (a…
63adc14 
…mpproject#37456)
@ampprojectbot ampprojectbot mentioned this pull request Feb 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcordry calebcordry calebcordry approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@powerivq @calebcordry @ampprojectbot