Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 [Analytics Parsely] Update host entry to use the new endpoint #39597

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

nbetm
Copy link
Contributor

@nbetm nbetm commented Nov 1, 2023

This PR replaces the parsely legacy host endpoint with the new one.

cc: @cwisecarver

@erwinmombay erwinmombay removed the request for review from caroqliu November 8, 2023 00:33
@cwisecarver
Copy link
Contributor

@erwinmombay Is there some way to retry the CircleCI job? It seems to be stuck. Thanks!

@nbetm
Copy link
Contributor Author

nbetm commented Jan 10, 2024

All tests passed. Ready to merge. Thanks, @erwinmombay.

@erwinmombay
Copy link
Member

approved. waiting on green build

@nbetm
Copy link
Contributor Author

nbetm commented Jan 19, 2024

@erwinmombay, the last commit was a green build. Please let me know if there's anything else needed to merge this PR.

@erwinmombay erwinmombay merged commit d3fba76 into ampproject:main Jan 31, 2024
43 checks passed
@erwinmombay
Copy link
Member

@nbetm sorry for delay. merged

eszponder pushed a commit to krzysztofequativ/amphtml that referenced this pull request Apr 22, 2024
…roject#39597)

* Update parsely host to use the new endpoint

* Update parsely host under test

* fix typo

* fix typo typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants