🐛 Connatix dock UI fullscreen support #39834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @alanorozco! These files were changed: |
powerivq
approved these changes
Feb 21, 2024
erwinmombay
requested review from
erwinmombay
and removed request for
alanorozco
erwinmombay
reviewed
Feb 21, 2024
| /** @override */ | ||
| fullscreenEnter() { | ||
| /** @override */ | ||
| fullscreenEnter() { |
There was a problem hiding this comment.
need to fix lint issues.
amp lint --fix --local_files should do the trick. (make sure you have committed all your changes first before running the command since it is destructive)
erwinmombay
approved these changes
Feb 22, 2024
powerivq
approved these changes
Feb 28, 2024
|
@cristisilav could you rebase against the latest main branch? That should fix the build issue. |
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
* Add Dock UI fullscreen button support * small fix * add break at end of switch statement * fix lint * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some changes on our player's side, we were able to finally update the flow in the AMP component that was required for enabling full dock UI fullscreen button functionality.