🏗 Simplify error reporting thresholds #39975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
force-pushed
the
error-reporting-thresholds
branch
from
3a3cdb9
to
b3aeb27
Compare
danielrozenberg
force-pushed
the
error-reporting-thresholds
branch
from
b3aeb27
to
1aa2e17
Compare
erwinmombay
approved these changes
Apr 26, 2024
erwinmombay
reviewed
Apr 26, 2024
| @@ -319,10 +334,7 @@ function onError(message, filename, line, col, error) { | |||
| } catch (ignore) { | |||
| // Ignore errors during error report generation. | |||
| } | |||
| if (hasNonAmpJs && Math.random() > 0.01) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asyncify various functions in the error-reporting.js file(dropped this change; it causes a big spike in bundle sizes for some reason)