Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚮 remove yahoo ad component as it is no longer in use nor working #40011

Merged
merged 3 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions 3p/integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,6 @@ import {wisteria} from '#ads/vendors/wisteria';
import {wpmedia} from '#ads/vendors/wpmedia';
import {wunderkind} from '#ads/vendors/wunderkind';
import {xlift} from '#ads/vendors/xlift';
import {yahoo} from '#ads/vendors/yahoo';
import {yahoofedads} from '#ads/vendors/yahoofedads';
import {yahoojp} from '#ads/vendors/yahoojp';
import {yahoonativeads} from '#ads/vendors/yahoonativeads';
Expand Down Expand Up @@ -583,7 +582,6 @@ register('wisteria', wisteria);
register('wunderkind', wunderkind);
register('wpmedia', wpmedia);
register('xlift', xlift);
register('yahoo', yahoo);
register('yahoofedads', yahoofedads);
register('yahoojp', yahoojp);
register('yahoonativeads', yahoonativeads);
Expand Down
12 changes: 0 additions & 12 deletions 3p/vendors/yahoo.js

This file was deleted.

5 changes: 0 additions & 5 deletions ads/_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -1492,11 +1492,6 @@ const adConfig = jsonConfiguration({
renderStartImplemented: true,
},

'yahoo': {
prefetch: 'https://s.yimg.com/aaq/ampad/display.js',
preconnect: 'https://us.adserver.yahoo.com',
},

'yahoofedads': {
renderStartImplemented: true,
},
Expand Down
17 changes: 0 additions & 17 deletions ads/vendors/yahoo.js

This file was deleted.

64 changes: 0 additions & 64 deletions ads/vendors/yahoo.md

This file was deleted.

9 changes: 0 additions & 9 deletions examples/amp-ad/ads.amp.esm.html
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@
<option>whopainfeed</option>
<option>wpmedia</option>
<option>xlift</option>
<option>yahoo</option>
<option>yahoojp</option>
<option>yahoonativeads</option>
<option>yandex</option>
Expand Down Expand Up @@ -2354,14 +2353,6 @@ <h2>Xlift native ad</h2>
data-mediaid="mamastar">
</amp-ad>

<h2>Yahoo Display</h2>
<amp-ad width="316" height="264"
type="yahoo"
data-sid="954014446"
data-site="news"
data-sa='{"LREC":"300x250","secure":"true","content":"no_expandable;"}'>
</amp-ad>

<h2>Yahoo Native Ads</h2>
<amp-embed width="320" height="320"
type="yahoonativeads"
Expand Down
6 changes: 0 additions & 6 deletions examples/amp-ad/ads.amp.html
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,6 @@
<option>whopainfeed</option>
<option>wpmedia</option>
<option>xlift</option>
<option>yahoo</option>
<option>yahoofedads</option>
<option>yahoojp</option>
<option>yahoonativeads</option>
Expand Down Expand Up @@ -2001,11 +2000,6 @@ <h2>Xlift native ad</h2>
<amp-ad width="300" height="300" type="xlift" data-mediaid="mamastar">
</amp-ad>

<h2>Yahoo Display</h2>
<amp-ad width="316" height="264" type="yahoo" data-sid="954014446" data-site="news"
data-sa='{"LREC":"300x250","secure":"true","content":"no_expandable;"}'>
</amp-ad>

<h2>Yahoo Native-Display Ads Federation</h2>
<amp-embed width="320" height="320" type="yahoofedads" layout="responsive" data-site="finance" data-region="US"
data-lang="en-US" data-ad-unit="pencil"
Expand Down
1 change: 0 additions & 1 deletion extensions/amp-ad/amp-ad.md
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,6 @@ See [amp-ad rules](validator-amp-ad.protoascii) in the AMP validator specificati
- [WPMedia](../../ads/vendors/wpmedia.md)
- [Wunderkind](../../ads/vendors/wunderkind.md)
- [Xlift](../../ads/vendors/xlift.md)
- [Yahoo](../../ads/vendors/yahoo.md)
- [YahooJP](../../ads/vendors/yahoojp.md)
- [Yandex](../../ads/vendors/yandex.md)
- [Yektanet](../../ads/vendors/yektanet.md)
Expand Down
9 changes: 0 additions & 9 deletions validator/testdata/feature_tests/ads.html
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@
<option>weborama</option>
<option>widespace</option>
<option>xlift</option>
<option>yahoo</option>
<option>yahoojp</option>
<option>yandex</option>
<option>yieldbot</option>
Expand Down Expand Up @@ -1267,14 +1266,6 @@ <h2>Xlift native ad</h2>
data-mediaid="mamastar">
</amp-ad>

<h2>Yahoo Display</h2>
<amp-ad width="316" height="264"
type="yahoo"
data-sid="954014446"
data-site="news"
data-sa='{"LREC":"300x250","secure":"true","content":"no_expandable;"}'>
</amp-ad>

<h2>YahooJP YDN</h2>
<amp-ad width="300" height="250"
type="yahoojp"
Expand Down
11 changes: 1 addition & 10 deletions validator/testdata/feature_tests/ads.out
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ PASS
| <option>weborama</option>
| <option>widespace</option>
| <option>xlift</option>
| <option>yahoo</option>
| <option>yahoojp</option>
| <option>yandex</option>
| <option>yieldbot</option>
Expand Down Expand Up @@ -1268,14 +1267,6 @@ PASS
| data-mediaid="mamastar">
| </amp-ad>
|
| <h2>Yahoo Display</h2>
| <amp-ad width="316" height="264"
| type="yahoo"
| data-sid="954014446"
| data-site="news"
| data-sa='{"LREC":"300x250","secure":"true","content":"no_expandable;"}'>
| </amp-ad>
|
| <h2>YahooJP YDN</h2>
| <amp-ad width="300" height="250"
| type="yahoojp"
Expand Down Expand Up @@ -1352,4 +1343,4 @@ PASS
| data-frame-id="_bda46cf5ac">
| </amp-ad>
| </body>
| </html>
| </html>