Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add new attribute to mgid and idealmedia ad components #40044

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

velichkin
Copy link
Contributor

We adding new attribute "website" to mgid and idealmedia ad components. It could be used instead legacy attributes "publisher" and "container" (they are still supported, but are not encouraged to use)

@powerivq powerivq self-assigned this Aug 8, 2024
@powerivq powerivq self-requested a review August 8, 2024 17:47
@powerivq
Copy link
Contributor

powerivq commented Aug 8, 2024

@velichkin Thanks for this PR. Do you work for MGID?

@velichkin
Copy link
Contributor Author

@velichkin Thanks for this PR. Do you work for MGID?

Yes, I do

@powerivq powerivq merged commit d384cbb into ampproject:main Aug 9, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants