Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❄️ Replace remote image URLs with local files in visual diff tests #40083

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/visual-tests/amp-story/amp-story-dev-tools.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
poster-portrait-src="./img/overview.jpg">
<amp-story-page id="cover">
<amp-story-grid-layer template="fill">
<amp-img src="https://images.unsplash.com/photo-1562907550-096d3bf9b25c"
<amp-img src="./img/laptop.jpg"
width="720" height="1280"
layout="responsive">
</amp-story-grid-layer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
poster-square-src="/examples/visual-tests/picsum.photos/image981_1600x1600.jpg">
<amp-story-page id="anchors">
<amp-story-grid-layer template="fill" preset="2021-background">
<amp-img src="https://images.unsplash.com/photo-1522072629756-c9274e34ef5e?w=1000&q=80"
<amp-img src="./lake.jpg"
layout="responsive" width="69" height="116">
</amp-img>
</amp-story-grid-layer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,16 @@
id="4-options-poll"
prompt-text="Which of these places would you travel to first?"
endpoint="https://webstoriesinteractivity-beta.web.app/api/v1"
option-1-image="https://images.unsplash.com/photo-1577416026704-0fe2d48a0f20?ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&ixlib=rb-1.2.1&auto=format&fit=crop&w=1500&q=80"
option-1-image="./img/lake-tahoe.jpg"
option-1-image-alt="Lake Tahoe"
option-1-confetti="🌲"
option-2-image="https://images.unsplash.com/photo-1506970845246-18f21d533b20?ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&ixlib=rb-1.2.1&auto=format&fit=crop&w=1500&q=80"
option-2-image="./img/hong-kong.jpg"
option-2-image-alt="Hong Kong"
option-2-confetti="🏙️"
option-3-image="https://images.unsplash.com/photo-1559494007-9f5847c49d94?ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&ixlib=rb-1.2.1&auto=format&fit=crop&w=668&q=80"
option-3-image="./img/hawaii.jpg"
option-3-image-alt="Hawaii"
option-3-confetti="🏝️"
option-4-image="https://images.unsplash.com/photo-1516302350523-4c29d47b89e0?ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&ixlib=rb-1.2.1&auto=format&fit=crop&w=1500&q=80"
option-4-image="./img/grand-canyon.jpg"
option-4-image-alt="Grand Canyon"
option-4-confetti="🏞️">
</amp-story-interactive-img-poll>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@
id="4-options-quiz"
prompt-text="Which of these structures is oldest?"
endpoint="https://webstoriesinteractivity-beta.web.app/api/v1"
option-1-image="https://images.unsplash.com/photo-1565475783696-96001eff1b45?ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&ixlib=rb-1.2.1&auto=format&fit=crop&w=1500&q=80"
option-1-image="./img/statue-of-liberty.jpg"
option-1-image-alt="Statue of Liberty"
option-1-correct
option-1-confetti="🎉"
option-2-image="https://images.unsplash.com/photo-1610312278520-bcc893a3ff1d?ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&ixlib=rb-1.2.1&auto=format&fit=crop&w=1460&q=80"
option-2-image="./img/golden-gate-bridge.jpg"
option-2-image-alt="Golden Gate Bridge"
option-3-image="https://images.unsplash.com/photo-1585436588477-340db86fc852?ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&ixlib=rb-1.2.1&auto=format&fit=crop&w=2804&q=80"
option-3-image="./img/cristo-redentor.jpg"
option-3-image-alt="Christ the Redeemer"
option-4-image="https://images.unsplash.com/photo-1543349689-9a4d426bee8e?ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&ixlib=rb-1.2.1&auto=format&fit=crop&w=1382&q=80"
option-4-image="./img/eiffel-tower.jpg"
option-4-image-alt="Eiffel Tower">
</amp-story-interactive-img-quiz>
</amp-story-grid-layer>
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added examples/visual-tests/amp-story/img/hawaii.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added examples/visual-tests/amp-story/img/lake.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added examples/visual-tests/amp-story/img/laptop.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading