services type fixes #4249
services type fixes #4249
Conversation
| @@ -219,6 +219,7 @@ export class Log { | |||
| * @param {...*} var_args Arguments substituted into %s in the message. | |||
| * @return {T} The value of shouldBeTrueish. | |||
| * @template T | |||
| * @throws {Error} | |||
There was a problem hiding this comment.
Lets not spam the code base with these.
There was a problem hiding this comment.
should i remove here then? didnt realize the compiler doesnt even use it besides detecting side effects
There was a problem hiding this comment.
Are you sure it is being used at all? I don't think so. Probably on externs
only.
On Jul 28, 2016 10:21 AM, "erwin mombay" notifications@github.com wrote:
In src/log.js
#4249 (comment):@@ -219,6 +219,7 @@ export class Log {
* @param {...*} var_args Arguments substituted into %s in the message.
* @return {T} The value of shouldBeTrueish.
* @template T
- * @throws {Error}
should i remove here then? didnt realize the compiler doesnt even use it
besides detecting side effects—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amphtml/pull/4249/files/7ef905fb26fde6d8e3f030df76a6c780dba8d889#r72581746,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFeT6itAXu5wks1ywbO7YO617Kpzhzvks5qaGZ9gaJpZM4JWvb9
.
There was a problem hiding this comment.
you are right, that is the case. "The type checker does not currently use this information. It is only used to figure out if a function declared in an externs file has side effects"
erwinmombay
force-pushed
the
type-pass-5
branch
5 times, most recently
from
524bd64
to
846769d
Compare
| @@ -124,7 +124,7 @@ export class Viewer { | |||
| /** @private {number} */ | |||
| this.prerenderSize_ = 1; | |||
|
|
|||
| /** @private {string} */ | |||
| /** @private {ViewportType} */ | |||
erwinmombay
force-pushed
the
type-pass-5
branch
2 times, most recently
from
66ba186
to
4473a3d
Compare
erwinmombay
force-pushed
the
type-pass-5
branch
from
4473a3d
to
f5f301f
Compare
|
@cramforce PTAL |
erwinmombay
force-pushed
the
type-pass-5
branch
from
f5f301f
to
5ff65fa
Compare
|
LGTM Idea: Comment the "Number of errors" after the change in each of these changes :) |
erwinmombay
force-pushed
the
type-pass-5
branch
from
5ff65fa
to
e49b11c
Compare
|
178 errors |
* more xhr type fixes * v-services type fixes
* more xhr type fixes * v-services type fixes
No description provided.