AMP Cache SW: No IndexedDB #4665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates the need for IndexedDB, and our IndexedDBP wrapper.
| * Fetches the request, and stores it in the cache. Since we only store one | ||
| * version of each file, we'll prune all older versions after we cache this. | ||
| * | ||
| * @param {!Request} request | ||
| * @param {string} requestFile the basename of the request | ||
| * @param {string} requestVersion the version of the request | ||
| * @return {!Promise<Response>} |
There was a problem hiding this comment.
nit: I believe fetch() is guaranteed to have a non-null response in the resolve case.
|
|
|
LGTM! |
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
* Use Cache as a primitive database This eliminates the need for IndexedDB, and our IndexedDBP wrapper. * Remove IndexedDB as Promised * Address comments
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
* Use Cache as a primitive database This eliminates the need for IndexedDB, and our IndexedDBP wrapper. * Remove IndexedDB as Promised * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important stuff's happening in the first commit.
Eliminates our IndexedDB usage from the AMP Cache Service Worker. That also means we can remove our IndexedDB as Promised wrapper lib, making the service worker ~671 bytes (it was 2.94 kB before).
Fixes #4650.