Convert some markdown to HTML #5978
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it |
|
CLAs look good, thanks! |
|
/to @bpaduch |
| @@ -168,11 +168,11 @@ HTML tags can be used unchanged in AMP HTML. Certain tags have equivalent custom | |||
| </tr> | |||
| <tr> | |||
| <td width="30%">form</td> | |||
| <td>Allowed. Require including [amp-form extension](../extensions/amp-form/amp-form.md).</td> | |||
| <td>Allowed. Require including <a href="../extensions/amp-form/amp-form.md">amp-form extension</a>.</td> | |||
There was a problem hiding this comment.
Instead of a relative url (due to main doc site import process), replace with this link: https://github.com/ampproject/amphtml/blob/master/extensions/amp-form/amp-form.md
| </tr> | ||
| <tr> | ||
| <td width="30%">input elements</td> | ||
| <td>Mostly Allowed with [exception of some input types](../extensions/amp-form/amp-form.md#inputs), namely, `input[type=image]`, `input[type=button]`, `input[type=password]`, `input[type=file]` are invalid. Related tags are also allowed: `fieldset`, `label`</td> | ||
| <td>Mostly Allowed with <a href="../extensions/amp-form/amp-form.md#inputs">exception of some input types</a>, namely, <code><input[type=image]></code>, <code><input[type=button]></code>, <code><input[type=password]></code>, <code><input[type=file]></code> are invalid. Related tags are also allowed: <code><fieldset></code>, <code><label></code></td> |
There was a problem hiding this comment.
Instead of a relative url, please replace with this link: https://github.com/ampproject/amphtml/blob/master/extensions/amp-form/amp-form.md#inputs-and-fields
|
@richadr - Do you want to implement the fixes, or shall I correct the doc? |
It is in a Markdown file, but inside a `<table>`, so it needs to be written as HTML, not as Markdown, in order to render properly.
…te import process)
|
@bpaduch - Apologies for the delay, the fixes are implemented now. I did a rebase and everything looks good. |
* Convert some markdown to HTML It is in a Markdown file, but inside a `<table>`, so it needs to be written as HTML, not as Markdown, in order to render properly. * Replace relative URL with absolute URL (needed because of main doc site import process)
* Convert some markdown to HTML It is in a Markdown file, but inside a `<table>`, so it needs to be written as HTML, not as Markdown, in order to render properly. * Replace relative URL with absolute URL (needed because of main doc site import process)
It is in a Markdown file, but inside a
<table>, so it needs to be written as HTML, not as Markdown, in order to render properly.