Add Cache SW manual test infrastructure #6532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good including the move of the extension code into a file with less deps. But don't you need to update some unit tests there? |
Yup, working on that next. |
|
@jridgewell Are there actually any changes to how we calculate extension URL? Or is it just refactoring to a separate module? |
|
No changes to how they're done, just extracted and added |
For some god awful reason, all of our polyfills were being pulled into the SW code because of the dependency chains.
The old code prevented a base directory from being used, like if we were serving from `http://localhost/dist`
jridgewell
force-pushed
the
cahce-sw-manual-testing
branch
2 times, most recently
from
bfc33f9
to
528873f
Compare
jridgewell
force-pushed
the
cahce-sw-manual-testing
branch
from
528873f
to
6e65f6a
Compare
jridgewell
force-pushed
the
cahce-sw-manual-testing
branch
from
f840e46
to
7d01922
Compare
|
PTAL |
cramforce
approved these changes
Dec 12, 2016
| @@ -108,7 +108,7 @@ runner.run('Cache SW', () => { | |||
| 'https://cdn.ampproject.org/rtv/123/v0.js'); | |||
| }); | |||
|
|
|||
| it('rewrites v1 to versioned v1', () => { | |||
| it.skip('rewrites v1 to versioned v1', () => { | |||
There was a problem hiding this comment.
Because we don't match v1 right now, only v0.
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Extract extensions-location from extensions-impl For some god awful reason, all of our polyfills were being pulled into the SW code because of the dependency chains. * Create calculateEntryPointScriptUrl * Ensure SW installs max code when asked * Update pathname rewriting in SW The old code prevented a base directory from being used, like if we were serving from `http://localhost/dist` * Add Cache SW manual test infrastructure * Remove unused export * Add tests * Fix tests
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Extract extensions-location from extensions-impl For some god awful reason, all of our polyfills were being pulled into the SW code because of the dependency chains. * Create calculateEntryPointScriptUrl * Ensure SW installs max code when asked * Update pathname rewriting in SW The old code prevented a base directory from being used, like if we were serving from `http://localhost/dist` * Add Cache SW manual test infrastructure * Remove unused export * Add tests * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6495.
/cc @dvoytenko for the extensions script url changes