Content.ad: Utilize sourceUrl for validation #6537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the Content.ad logic to use the sourceUrl value for publisher domain validation.
|
Travis CI threw the following error: Please confirm and restart the test. |
lannka
approved these changes
Dec 8, 2016
|
@lannka I don't understand why I'm getting the following error in the Travis CI test. I defined my |
|
Could you try adding the following line here And then run |
|
@lannka looks like that did the trick. Am I allowed to modify |
|
Definitely. Thanks for the fix. |
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Content.ad: Utilize sourceUrl for validation Updated the Content.ad logic to use the sourceUrl value for publisher domain validation. * Expose sourceUrl to ads
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Content.ad: Utilize sourceUrl for validation Updated the Content.ad logic to use the sourceUrl value for publisher domain validation. * Expose sourceUrl to ads
This was referenced May 2, 2021
This was referenced May 22, 2021
This was referenced Jun 2, 2021
This was referenced Jun 16, 2021
This was referenced Jun 28, 2021
This was referenced Aug 23, 2023
This was referenced Sep 9, 2023
This was referenced Sep 16, 2023
This was referenced Sep 24, 2023
This was referenced Oct 10, 2023
This was referenced Oct 19, 2023
This was referenced Oct 26, 2023
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Content.ad logic to use the sourceUrl value for publisher domain validation.