Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup from pr comments on #7599 #7838

Merged
merged 1 commit into from
Mar 1, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/amp-bind/0.1/bind-evaluator.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export class BindEvaluator {
const expression = this.expressionCache_[expressionString];
if (!expression) {
const error =
new Error(`Expression "${expressionString}"" is not cached.`);
new Error(`Expression "${expressionString}"" is not cached.`);
errors[expressionString] = {message: error.message, stack: error.stack};
return;
}
Expand All @@ -126,7 +126,7 @@ export class BindEvaluator {
cache[expressionString] = result;
} else {
const error =
new Error(`"${result}" is not a valid result for [${property}].`);
new Error(`"${result}" is not a valid result for [${property}].`);
errors[expressionString] = {message: error.message, stack: error.stack};
}
});
Expand Down
6 changes: 3 additions & 3 deletions extensions/amp-bind/0.1/bind-impl.js
Original file line number Diff line number Diff line change
Expand Up @@ -430,9 +430,9 @@ export class Bind {
const elements = this.expressionToElements_[expressionString];
if (elements.length > 0) {
const evalError = errors[expressionString];
const err = user().createError(evalError.message);
err.stack = evalError.stack;
reportError(err, elements[0]);
const userError = user().createError(evalError.message);
userError.stack = evalError.stack;
reportError(userError, elements[0]);
}
});
});
Expand Down