-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amp-bind: Rearrange grammar rules and regenerate parser #8046
Conversation
@@ -884,4 +884,20 @@ Parser.prototype = parser;parser.Parser = Parser; | |||
return new Parser; | |||
})(); | |||
|
|||
exports.parser = parser; | |||
|
|||
if (typeof require !== 'undefined' && typeof exports !== 'undefined') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's part of the autogenerated file. I'm not sure if they added this in the newest version of jison or if @choumx just removed it from previous versions.
EDIT: Judging from the CI error it's the latter. I'll remove it now.
15e5da4
to
a4e5c27
Compare
With the changes to the performance HTML file and the parser, the time it takes Bind to parse bindings on performance.html decreased by 10% on my machine. (Chrome 56, CPU throttling at 10x, two different experiments with 10 tries each comparing master's bind-expr-impl.js to the one on this branch, web-worker experiment disabled)
/to @choumx, @jridgewell