Creates a timeout for preconnects #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
force-pushed
the
preconnect-expiration
branch
from
9f23417
to
13c00cf
Compare
| @@ -34,7 +34,7 @@ describe('preconnect', () => { | |||
| }); | |||
|
|
|||
| afterEach(() => { | |||
| clock.tick(20000); | |||
| clock.tick(200000); | |||
There was a problem hiding this comment.
are you sure you want 200,000 ms?
There was a problem hiding this comment.
Sure. This just makes sure there is nothing left to do.
requests. This may happen when we preconnect super early but when do not actually render the element for a while. Switches preconnecting to a callback that gets called 2x per element: 1. At built time. 2. Just after layoutCallback to parallelize requests. Related ampproject#870 (Does not affect only calling preconnect when doc becomes visible)
cramforce
force-pushed
the
preconnect-expiration
branch
from
13c00cf
to
4f9fffa
Compare
cramforce
added a commit
that referenced
this pull request
Nov 18, 2015
Creates a timeout for preconnects
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after which they will be done again if requests. This may happen when we preconnect super early but when do not actually render the element for a while.
Switches preconnecting to a callback that gets called 2x per element:
Related #870 (Does not affect only calling preconnect when doc becomes visible)