Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run integration tests on SauceLabs and run them in more browsers. #896

Merged
merged 1 commit into from
Nov 18, 2015

Conversation

cramforce
Copy link
Member

Related to #895
Fixes #879

@erwinmombay
Copy link
Member

LGTM

@@ -22,5 +22,5 @@ script:
- gulp build
- gulp dist
- gulp presubmit
- gulp test
- gulp test --saucelabs
- gulp test --unit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do we check for the unit flag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent change. But removed it. I really only need !argv.integration

cramforce added a commit that referenced this pull request Nov 18, 2015
Only run integration tests on SauceLabs and run them in more browsers.
@cramforce cramforce merged commit c63b273 into ampproject:master Nov 18, 2015
@cramforce cramforce deleted the integration branch November 18, 2015 15:49
@qidonna qidonna mentioned this pull request Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants