Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-insensitive sanitizing of attribute values #917

Merged
merged 1 commit into from
Nov 13, 2015

Conversation

dvoytenko
Copy link
Contributor

No description provided.

@@ -72,8 +72,12 @@ describe('sanitizeHtml', () => {
expect(sanitizeHtml('a<a onclick="alert">b</a>')).to.be.equal('a<a>b</a>');
expect(sanitizeHtml('a<a style="color: red;">b</a>')).to.be.equal(
'a<a>b</a>');
expect(sanitizeHtml('a<a STYLE="color: red;">b</a>')).to.be.equal(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also uppercase tag name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@cramforce
Copy link
Member

LGTM

dvoytenko added a commit that referenced this pull request Nov 13, 2015
Case-insensitive sanitizing of attribute values
@dvoytenko dvoytenko merged commit 50c1fbc into ampproject:master Nov 13, 2015
@dvoytenko dvoytenko deleted the sanitizer2 branch November 13, 2015 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants