UrlReplacements refactoring for amp-pixel and amp-list #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I need this as well. |
| } | ||
|
|
||
| /** | ||
| * @return {!RegExpr} |
|
LGTM |
| const expr = this.getExpr_(); | ||
| return url.replace(expr, (match, name) => { | ||
| let val = this.replacements_[name](opt_data); | ||
| if (!val && val !== 0) { |
There was a problem hiding this comment.
can you explain when it will be 0? or did you mean to check length?
There was a problem hiding this comment.
No, we allow numbers as return values and most other types too. So, I'm special-casing 0 in this case since it's a sensible numeric value for our substitutions.
There was a problem hiding this comment.
is that document anywhere btw?
There was a problem hiding this comment.
Added docs right there.
|
LGTM |
dvoytenko
added a commit
that referenced
this pull request
Nov 17, 2015
UrlReplacements refactoring for amp-pixel and amp-list
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both amp-pixel and amp-list (and others in the future) will be able to take advantage of default substitutions and customize for their own needs.
Partial for #657.
/cc @cramforce