Initial contribution of the validator #951
Conversation
|
@erwinmombay Could you also take a look. |
| @@ -0,0 +1,201 @@ | |||
| Apache License | |||
|
Does it make sense to also check in the generated JSON, so we can use the validator without the complicated build process? |
|
@cramforce will do |
|
I'd like to not check this generated stuff in initially, just so that there is a clean checkin. I think it's better to figure out what you need to have checked in once it's clear how you want to use it. To see what this generates (actually Javascript, not json), I stuck it up as well. |
|
Definitely, lets get this in quickly. I'm fine with merging with the 2 comments above resolved. |
| "name": "amp_validator", | ||
| "version": "0.1.0", | ||
| "description": "Validator for AMP HTML (www.ampproject.org)", | ||
| "main": "index.js", |
There was a problem hiding this comment.
is there actually an index.js file?
There was a problem hiding this comment.
There is one, but not included in this PR. The purpose of package.json is to let build.py fetch the dependencies, so index.js isn't used for anything, and build.py contains a snippet which generates its own main method, available (when built) as ./codegen/validate. I'll remove this line and see how it goes.
There was a problem hiding this comment.
Turns out this "main": entry does nothing, so I got rid of it.
|
@cramforce should we whitelist |
|
@erwinmombay whitelisting everything but the license check is fine (or at least make sure we pass that check). When we make this the master repo for the validator we can bring everything up to pass. |
| <link rel="canonical" href="./regular-html-version.html" /> | ||
| <meta name="viewport" content="width=device-width,minimum-scale=1"> | ||
| <style>body {opacity: 0}</style><noscript><style>body {opacity: 1}</style></noscript> | ||
| <script src="https://ssl.gstatic.com/amphtml/v0.js" async></script> |
There was a problem hiding this comment.
move async as the first prop for best practices. (i can make this change later, just marking it for now)
|
@cramforce removed the two files. |
|
@cramforce created #953 |
@powdercloud of Google, with credits given to original versions for the css parser/tokenizer and the html parser in the file headers. This is the validator which is already used by the amphtml developer mode; see also https://github.com/ampproject/amphtml#the-amp-validator README.md describes how to build this; there's currently only a minimal ad-hoc build script, build.py, which should work for Ubuntu 14. We still need to contribute our tests (we do have tests), so this is only a first step.
|
Looks like the checks are green now, thanks to you. |
|
LGTM, deferring to @cramforce for final LGTM |
|
LGTM. Merging. |
Initial contribution of the validator
Written by @Gregable and @powdercloud of Google,
with credits given to original versions for the
css parser/tokenizer and the html parser in the file headers.
This is the validator which is already used by the amphtml developer mode;
see also https://github.com/ampproject/amphtml#the-amp-validator
README.md describes how to build this; there's currently only a minimal
ad-hoc build script, build.py, which should work for Ubuntu 14.
We still need to contribute our tests (we do have tests), so this is
only a first step.