Several small improvements to error reporting: #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cramforce
commented
Nov 19, 2015
cramforce
commented
- Use the application name to make filtering by assert possible.
- Return HTTP 204 as appropriate.
- better handling for case of no error message.
- Use the application name to make filtering by assert possible. - Return HTTP 204 as appropriate. - better handling for case of no error message.
| @@ -99,13 +99,17 @@ func handle(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| // Fill query params into JSON struct. | |||
| line, _ := strconv.Atoi(r.URL.Query().Get("l")) | |||
| errorType := "default" | |||
| if r.URL.Query().Get("a") == "1" { | |||
There was a problem hiding this comment.
qq, what does a stand for here?
There was a problem hiding this comment.
That the error came from an assert. Thought it was obvious given the thing that happens next.
There was a problem hiding this comment.
oh i did infer it. just wanted to make sure :)
|
LGTM |
cramforce
added a commit
that referenced
this pull request
Nov 20, 2015
Several small improvements to error reporting:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.