Implement a page view id. #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
force-pushed
the
page-view-id
branch
3 times, most recently
from
5fe7b6d
to
fe52a9d
Compare
cramforce
force-pushed
the
page-view-id
branch
from
fe52a9d
to
37b7ece
Compare
|
Fixed test |
|
|
||
|
|
||
| /** | ||
| * This class replaces substitution variables with their values. | ||
| */ | ||
| export class UrlReplacements { | ||
| class UrlReplacements { |
There was a problem hiding this comment.
These were two reasons why I exported the class:
- Avi was saying that he wanted to customize url replacements for analytics that only applied there.
- I wanted to keep it extensible for amp-list for infinite scroll. E.g. "https://service/list.json?page=PAGE", where a hypothetical "PAGE" var would only be available in the context of amp-list.
There was a problem hiding this comment.
I think we can do it when we get there. For now a service seems a natural fit here. I think for other use cases, just replacing the raw replacement functionality might be better than inheritance.
There was a problem hiding this comment.
It's been intended as composition, not inheritance. If we proceed as a singleton, let's hide "set" method.
cramforce
force-pushed
the
page-view-id
branch
from
37b7ece
to
49c4d54
Compare
|
LGTM once |
The id is relatively likely to be unique per page load, URL and user. 1/2 of ampproject#969
cramforce
force-pushed
the
page-view-id
branch
from
49c4d54
to
d306504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The id is relatively likely to be unique per page load, URL and user.
Fixes page view id part of #969