Updated Dockerfiles for consumer and renewer #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…educe docker image sizes from 2GB to 12.3MB
twifkak
approved these changes
Mar 9, 2020
| # Start the AMP Packager | ||
| ENTRYPOINT ["amppkg"] | ||
|
|
||
| # Set default flags to run in development mode. | ||
| # Set default flags to run in autorenew cert mode. | ||
| CMD ["-autorenewcert", "-config=/renewer/amppkg_renewer.toml"] |
There was a problem hiding this comment.
Have you considered making this inherit from Dockerfile.consumer to reduce duplication?
There was a problem hiding this comment.
Certainly possible but decided to keep them separate for now until everything settles down. We may revisit for a future PR.
cpapazian
pushed a commit
to cpapazian/amppackager
that referenced
this pull request
May 19, 2020
* Updated Dockerfiles for consumer and renewer to use multi-stage and reduce docker image sizes from 2GB to 12.3MB * Added comments to sync up consumer file to renewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Dockerfiles for consumer and renewer to use multi-stage and reduce docker image sizes from 2GB to 12.3MB