Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace csp-collector.appspot.com with csp.withgoogle.com #403

Merged
merged 4 commits into from
Mar 31, 2020
Merged

Replace csp-collector.appspot.com with csp.withgoogle.com #403

merged 4 commits into from
Mar 31, 2020

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Mar 12, 2020

The URI end-point for the CSP Collector used by AMP was changed recently.

This PR adds the new URI as a valid option for SxG.

The URI end-point for the CSP Collector used by AMP was changed recently.

This PR adds the new URI as a valid option for SxG.
@rsimha
Copy link
Contributor Author

rsimha commented Mar 12, 2020

/to @twifkak for review
/cc @Gregable

@twifkak twifkak self-requested a review March 18, 2020 18:03
@rsimha
Copy link
Contributor Author

rsimha commented Mar 18, 2020

@twifkak Let me know if the coast is clear to merge this PR, now that the internal changes have been submitted.

@twifkak
Copy link
Member

twifkak commented Mar 18, 2020

@rsimha Yep, pending b/151840041.

@twifkak twifkak merged commit 0f7c4fb into ampproject:master Mar 31, 2020
@rsimha rsimha deleted the patch-1 branch March 31, 2020 22:27
cpapazian pushed a commit to cpapazian/amppackager that referenced this pull request May 19, 2020
…ject#403)

The URI end-point for the CSP Collector used by AMP was changed recently.

This commit changes the report-uri to match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants