Add gateway request latency Prometheus metric. #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another metric per request ampproject#357.
banaag
approved these changes
May 28, 2020
packager/signer/signer.go
Outdated
| ) | ||
|
|
||
| func (this *Signer) fetchURLAndMeasure(fetch *url.URL, serveHTTPReq *http.Request) (*http.Request, *http.Response, *util.HTTPError) { | ||
| now := time.Now() |
There was a problem hiding this comment.
you might want to stub out 'now' so it's easier to inject your own now in tests.
There was a problem hiding this comment.
Thanks a lot, this is a very cool idea! I didn't do this for top level
requests because latencies are measured by a third-party (Prometheus :),
but it can be done here.
Done.
|
Thanks a lot, this is a very cool idea! I didn't do this for top level
requests because latencies are measured by a third-party (Prometheus :),
but it can be done here. Will do.
…On Thu, May 28, 2020 at 11:47 AM Allan Banaag ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In packager/signer/signer.go
<#429 (comment)>
:
> +// promGatewayRequestsLatency is a Prometheus summary that observes requests latencies.
+// Objectives key value pairs set target quantiles and respective allowed rank variance.
+// Upon query, for each Objective quantile (0.5, 0.9, 0.99) the summary returns
+// an actual observed latency value that is ranked close to the Objective value.
+// For more intuition on the Objectives see http://alexandrutopliceanu.ro/post/targeted-quantiles/.
+var promGatewayRequestsLatency = promauto.NewSummaryVec(
+ prometheus.SummaryOpts{
+ Name: "gateway_request_latencies_in_seconds",
+ Help: "Latencies (in seconds) of gateway requests to AMP document server - by HTTP response status code.",
+ Objectives: map[float64]float64{0.5: 0.05, 0.9: 0.01, 0.99: 0.001},
+ },
+ []string{"code"},
+)
+
+func (this *Signer) fetchURLAndMeasure(fetch *url.URL, serveHTTPReq *http.Request) (*http.Request, *http.Response, *util.HTTPError) {
+ now := time.Now()
you might want to stub out 'now' so it's easier to inject your own now in
tests.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#429 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD6UM4DHSZH4H3YIOS6BFDRT2WSVANCNFSM4NNKG46Q>
.
--
Mike Rybak | SWE on AMP Conduit team | g <http://go/amphtml-conduit>
o/amphtml-conduit <http://go/amphtml-conduit>
|
banaag
approved these changes
May 28, 2020
twifkak
approved these changes
May 29, 2020
packager/signer/signer.go
Outdated
| @@ -142,14 +143,14 @@ func noRedirects(req *http.Request, via []*http.Request) error { | |||
|
|
|||
| func New(certHandler certcache.CertHandler, key crypto.PrivateKey, urlSets []util.URLSet, | |||
| rtvCache *rtv.RTVCache, shouldPackage func() error, overrideBaseURL *url.URL, | |||
| requireHeaders bool, forwardedRequestHeaders []string) (*Signer, error) { | |||
| requireHeaders bool, forwardedRequestHeaders []string, timeNowFunc func() time.Time) (*Signer, error) { | |||
There was a problem hiding this comment.
The list of constructor args is getting pretty long. We should (passively) start thinking of ways to split up responsibility of this class. I don't have any ideas; this is just me creating entropy. :P
packager/signer/signer.go
Outdated
| @@ -134,6 +134,7 @@ type Signer struct { | |||
| overrideBaseURL *url.URL | |||
| requireHeaders bool | |||
| forwardedRequestHeaders []string | |||
| timeNowFunc func() time.Time | |||
There was a problem hiding this comment.
(opt) Maybe remove "Func" from the name? It's kind of implied, as a non-func Time couldn't be "now".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another metric per request #357.