FIXIT: Generate a better error for incorrectly generated private key #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twifkak
approved these changes
Jun 8, 2020
packager/util/util.go
Outdated
| @@ -52,7 +52,7 @@ func ParsePrivateKey(keyPem []byte) (crypto.PrivateKey, error) { | |||
| var pemBlock *pem.Block | |||
| pemBlock, keyPem = pem.Decode(keyPem) | |||
| if pemBlock == nil { | |||
| return nil, errors.New("invalid PEM block in private key file") | |||
| return nil, errors.New("invalid PEM block in private key file, make sure to use the right key type. Generate the key using: openssl ecparam -out priv.key -name prime256v1 -genkey") | |||
There was a problem hiding this comment.
Maybe instead of inlining the openssl command, link to "step 2 of https://github.com/WICG/webpackage/tree/master/go/signedexchange#creating-our-first-signed-exchange", which includes the necessary command to regenerate the cert, too.
Alternatively, we could update our README or our wiki to include this information, and link to that.
twifkak
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #354