-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 7 of AMP cache transforms #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
call of t.Fatalf copies lock value: github.com/ampproject/amppackager/transformer/request.Request contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex PiperOrigin-RevId: 362115014
PiperOrigin-RevId: 362183596
PiperOrigin-RevId: 363257129
PiperOrigin-RevId: 363427993
PiperOrigin-RevId: 363521960
…omodule scripts. PiperOrigin-RevId: 363771272
Don't accept an OCSP response if its ProducedAt is outside the leaf cert's NotBefore/NotAfter validity window.
Validates that they all fall within the NotBefore/NotAfter of the certificate.
Update the permalink to the extractPreloads function to document the newly allowed crossorigin attribute, added in commit 684426c. Remove the permalink to formatLinkHeader since Google's link parser is no longer as picky about serialization.
`crossorigin` was allowed in ampproject/amphtml#29104. PiperOrigin-RevId: 365663795
PiperOrigin-RevId: 366516313
Links to the new v0.mjs CSP added by commit e581627.
CSP requirement was loosened to allow any (or no) report-uri.
…e have a suitable replacement. This enables ESM-optimized AMP to be styled correctly in AMP Packager, as the mjs runtime does not include a fallback copy of the CSS. PiperOrigin-RevId: 368897273
…loads. A future commit will format this properly in signer.go. PiperOrigin-RevId: 369289290
As introduced in commit 8fbd1a7.
This allows the later AMPRuntimeCSS transformer to decide whether to keep the existing style or not, for pages that have been optimized. PiperOrigin-RevId: 369332817
PiperOrigin-RevId: 369673941
Gregable
approved these changes
Apr 22, 2021
twifkak
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release version 7 of AMP cache transforms