✨ 🏗 Move over Bento src code from amphtml #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
force-pushed
the
move-bento-src
branch
5 times, most recently
from
389b5d5
to
2f401b4
Compare
rileyajones
force-pushed
the
move-bento-src
branch
from
2f401b4
to
068f7f8
Compare
* tmp * Fixes * Wrap HTMLElement if Reflect.construct is available * Completely isolate code from globals * Install in child win * Fix * Remove document-register-element * Rename file * Fix types * Experimentally use new custom elements polyfill * Register custom-elements-v1 experiment * Fix comment * Include custom elements polyfill with module build * Fix build system * Bump build size * tmp * Copious comments * Use CustomElementsV1 in all tests * Defer MutationObserver start * Remove unused code Though I was collecting `connectedCallback` and `disconnectedCallback`, I wan't actually using these values. I was calling them directly off the prototye intead. While not spec compliant, it's good enough. It also saves bytes. * Add todos * Fix describes * Update form-proxy inheritance to account for polyfill * Fix "dangerous use of global this" * Review comments * Use V1 in tests
* fix parenthesis removal when preprocessing with babel * add preprocessing * add tmp directory to module_root path * assert removal must be post process instead of pre process to appease type checking * temp * add more explanation * add tracking issue to comment hacks
* Synchronous custom elements * Update src/polyfills/custom-elements.js
* Allow forcing the Custom Elements V1 Polyfill Omitting the `ctor` when installing the CE V1 polyfill will now force the full polyfill installation, since we can't properly test if Native Classes are being used (necessary for proper native support). This will allow us to launch the new polyfill without native CE support, which is the riskiest part of the transition. * Rethrow Custom Element callbacks out-of-loop * Patch the prototype, not the instance * Track shadow trees * Fix types * Support createShadowRoot * Fix shadow amp
* web-worker: Set error reporter - Set an error reporter in web-worker so dev().error() can be used without erroring-out itself. - Revise several oft-imported classes to allow importing within a document-less context. * web-worker: Spelling correction * polyfills: Add comments, improve readability
…468) * CEv1: Only upgrade nodes if ownerDocument matches registry doc There was a bug where cloning in/out of a `<template>` would upgrade the custom element nodes even if the tree belonged to the template's document (which is distinct from the page's document). * Avoid "global" this usage
* Use __proto__ instead of setPrototypeOf We're getting an error from `setPrototypeOf` somehow not being a method on `Object`. * WHY DO I ALWAYS DO THIS?!?!
* Launch Custom Elements v1 Polyfill There don't seem to be any errors. Let's launch! * Always use customElements registry * Fix isPatched check IE11 doesn't have `"[native code]"`, instead it returns `"[object HTMLElement]"`. Well, if there's no CE, then we obviously need to polyfill anyways. * Fix IE11 innerHTML overwrite IE11 puts the `innerHTML` accessor on `HTMLElement.prototype`, not `Element.prototype`. And we've already replaced `HTMLElement` with our polyfill class. That polyfill class directly inherits from the native `HTMLElement`, so we can access it via the `__proto__` field.
When we transpile `super` in Custom Element subclasses, we change it to `superClass.call(this)` (where `superClass` is `HTMLElementPolyfill`). That `.call` value is inherited from `Function.prototype`. But, IE11's native HTMLElement hierarchy doesn't extend from Function! And because `HTMLElementPolyfill` extends from `HTMLElement`, it doesn't have a `.call`! So we need to manually install it.
* Upgrade shadow root contents when defining new CEs When we've already initialized the the custom element registry, it used to drop the list of shadow roots. When a new CE was defined, we would then only query the host `document` (since we dropped all the shadow roots from the array). Obviously, that query selector won't find CEs inside the shadow tree. So, we need to keep the list of shadow roots, that way we can query inside them when defining new custom elements. Note, this will mean leaking every shadow permenantly. Even if the shadow's host is removed from the document, we'll still have to keep its reference. We could setup a long running interval to find disconnected trees, but it wouldn't be able to tell the difference between a temporarily disconneded shadow and a destoyed shadow. * Fix comment * Remove unused private
It also directly calls into the globally installed error reporting function. Re: ampproject/amphtml#25289 It seems HTML spec is unlikely to change: whatwg/html#5051
Closure compiler was eliminating the `opt_ctor.call(instance)` line as useless. This had no real effect on us, because we're transpiling our code. But, in a world where we shipped native `class` code to browsers, this would have resulted in use wrapping the `HTMLElement` class unnecessarily. Not the full polyfill, but the minimal polyfill. Fixing this will allow us to eventually use no polyfill on when we ship native classes.
* CEv1: Support IE10 This adds IE10 support to the Custom Elements v1 polyfill. IE10 doesn't support `Object.setPrototypeOf`, so we must fake it by recursively copying over all properties from the prototype to the base object. * Fix
* Remove Object param * Test and fix copyProperties * fix * fix
* Add new rewrite-imports babel plugin This plugin transforms the collquial name into the fully qualified import path. This is necessary for the new preact integrations, since `preact/hooks` actually does `import * from 'preact'`. We can't directly import `preact` like that, it has to be the `preact/dist/preact.module.js` path so Closure will work correctly. * Simplify ExportDeclaration visitor * Copyright year * Lint * Simplify * use package.json field to resolve to module * tmp * tmp * tmp * tmp * Import directly from preact * Use amp-context notify to sync with Resource * Tests * Remove useless break * Fix types * Fix defs naming clash * Use matches helper * Update validator-amp-date-display.out * Fix issues with module compilation in single-pass * Just import from the full worker-dom source * Update copyright year * Undo example layout change * Reorder functions * Remove getContextFromDom * Switch to using vsync system * Simplify preact utils * Require experiment to be on * fix type * Use object-spread * Flip prop-attrs definition * Separate dom-rendering concern from amp-date-display * Fix arguments * Add required useResourcesNotify * Fix tests * Add preact modules to the sources list * Include preact package.json * Fix name mangling of properties * Split out Preact components into their own files * Move PreactBaseElement into src/preact dir * Remove unused code * Update copyright years * Types * Remove unused imports * Patch preact with types * Fully type Preact API by using intermediate module * Strengthen types * Types and minification * React tests * Fix sinon imports * Rearrange methods * Lint * Remove file * Convert PreactBaseElement into a subclass-able subclass * Convert to static fields
* 📦 Update dependency google-closure-compiler to v20200112 * Fix `gulp check-types` * Fix `gulp validator` Co-authored-by: Raghu Simha <rsimha@amp.dev>
* Use typeof instead of new * Change Function to a typeof Constructor * lint
* Launch minmal wrapper native CEv1 * Add comment
* Allow JSX syntax * Add react transform * Switch to Preact namespace * Copy sourcemaps for pre-closure babel transforms * Fix packages * Add preact eslint rule * Fixup plugins and sourcemaps * lint * Update Preact Types Defs * Undo sourcemap changes * Fix leading comments React constant elements was hoisting a cached value between the JSDoc comment and value it annotated. This is beacuse the comment was actually attached to the previous node as a trailing comment. * Fix Fragment reference * Perform single-pass browserify crawl in TMP directory
* Use quoted properties to prevent Closure's DCE * Fix mangling
…rectory (#36639) * update build-system to build bento components stored in a new directory and move jwplayer
* preact parseProps: only match elements * node->element:
We've been incorrectly mapping `tabIndex` as the Preact-style prop name and `tabindex` as the React-style prop name. This should be reversed.
* feature(bento-add-banner): initial template generation * feature(bento-add-banner): created simple storybook * feature(bento-add-banner): copied CSS from classic * feature(bento-add-banner): added many "stubs" for standalone services * feature(bento-add-banner): ported IOS and Android app logic * feature(bento-add-banner): added platform-aware logic, and dismiss button storage * feature(bento-add-banner): added UI unit tests * feature(bento-add-banner): added IOS tests * feature(bento-add-banner): moved sources into `component` folder * feature(bento-add-banner): added unit tests for Android * feature(bento-add-banner): mapped the `dismiss-button-aria-label` attribute * feature(bento-add-banner): added minor notes to the stories * feature(bento-add-banner): added unit tests for amp-app-banner * feature(bento-add-banner): updated validator * feature(bento-add-banner): extracted services to common location * feature(bento-add-banner): added README for services * feature(bento-add-banner): updated type defs * feature(bento-add-banner): updated formatting * feature(bento-add-banner): lint fix * feature(bento-add-banner): lint ignores * feature(bento-add-banner): lint fixes * feature(bento-add-banner): type fixes * feature(bento-add-banner): updated z-index file * feature(bento-add-banner): updated validator template * feature(bento-add-banner): simplified code with `Array.find` * feature(bento-add-banner): parse meta content using `Array.reduce` * feature(bento-add-banner): added more tests for android * feature(bento-add-banner): added more tests for ios * feature(bento-add-banner): improved tests for BentoAppBanner * feature(bento-add-banner): added tests for Dismiss logic * feature(bento-add-banner): added more iOS tests * feature(bento-add-banner): tiny lint fix * feature(bento-add-banner): improved tests for web-component mode, and fixed the button[open-button] check * feature(bento-add-banner): removed unnecessary `waitFor` * feature(bento-add-banner): lint fix * feature(bento-add-banner): added whitespace in tests * feature(bento-add-banner): ensure tests are not dependent on timers * feature(bento-add-banner): removed obsolete `latestVersion` * feature(bento-add-banner): use `Object.fromEntries` as suggested * feature(bento-add-banner): removed unused CSS * feature(bento-add-banner): use `WindowInterface.getTop` to improve unit tests * feature(bento-add-banner): extracted querySelectorInSlot to core * feature(bento-add-banner): removed useless services, use object-syntax instead of classes, fixed fetchJson * feature(bento-add-banner): renamed services to utils * feature(bento-add-banner): removed redundant win variable * feature(bento-add-banner): extracted parsing logic into separate function for readability * feature(bento-add-banner): renamed file to `docInfo` * feature(bento-add-banner): improved safety of accessing localStorage * feature(bento-add-banner): ensure proper default value is returned * feature(bento-add-banner): removed unnecessary async * feature(bento-add-banner): ensure localStorage still works if `key` changes * feature(bento-add-banner): flip ternary for readability * feature(bento-add-banner): added `self` for fetch * feature(bento-add-banner): updated generated z-index file * feature(bento-app-banner): ensure XHR rejects invalid status codes * feature(bento-app-banner): removed dependencies on `/src/url` * feature(bento-app-banner): lint sample code * feature(bento-app-banner): minor code improvements * feature(bento-app-banner): minor code improvements * feature(bento-app-banner): minor code improvements * feature(bento-app-banner): allow localStorage from custom hook * feature(bento-app-banner): include optional `init` param for requests * feature(bento-app-banner): improved logging * feature(bento-app-banner): only expose `logger[info|warn|error]` * feature(bento-app-banner): warn when localStorage.setItem fails * feature(bento-app-banner): ensure logger can be stubbed and tested * feature(bento-app-banner): moved `INVALID_PROTOCOLS` to proper location * feature(bento-app-banner): ensure logger is globally disabled * feature(bento-app-banner): ensure component inherits from AmpPreactBaseElement * Update src/preact/utils/docInfo.js Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: scottrippey <scott.william.rippey@gmail.com> Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
* bento extensions: support jsx/tsx, and typed imports * unfix sourcemap * rcebulko comments * update resolvePath * add comment
* src/preact: convert first file to tsx * fix storybook
…ents/bento-jwplayer` (#37519) * the name set in the bundle config file actually needed to include either amp or bento... * rename src/bento/components/jwplayer -> src/bento/components/bento-jwplayer
* src/preact: use URL instead of parseUrlDeprecated * address jridgewell feedback * force toString conversion
…473) * move amp accordion bento component to src/bento
* begin building bentoproject/core * surface extension css over npm * fix remap dependencies to handle tsx * handle trailing slash in importPath (necessary when remap-ing non-node_modules) * support building extensions using bentoproject/core
* Remove @nocollapse annotation which was closure-specific. * lint * remove validator change which may actually still use closure
On `module` builds, use browser's `import` statement to share Bento dependencies like `bento.mjs`.
On `nomodule` builds, we can't use `import`. Instead, we use babel to output to a format similar to AMD.
This change also simplifies some aspects:
- Prefers using `{remapDependencies}` for esbuild rather than `module-resolver` on babel.
- Removes `bento` compile wrapper.
- Removes generators. Uses `src/bento.js` directly, and the intermediate `bento-shared.js` module is no longer needed.
* Add PREVIEW visibility state * Add previewAllowed method to custom/base element * Add previewAllowed method to resource class * Handle preview AmpDoc visibility state * Add TODO/clarifying comments * Handle build scheduling for preview mode * Handle preview viz state in amp-video * Update resources-impl to handle preview like prerender * Add TODO comment re: opting preview out of prerender build quota * Fixup * Add tests or TODOs where needed * Exempt PREVIEW from build quota * Add tests for PREVIEW in scheduler * Add tests for PREVIEW in resources * Add tests for PREVIEW in analytics visibility manager * Remove TODO from viewer-impl & amp-story-player-impl * Preview is visible; include in state machine * test-visibility-states * Remove deprecated eslint-disable * Revert isVisible change * samouri nit fixes * Remove nopreview attribute * Fix test for Preact base-element change
* feature(bento-add-banner): initial template generation * feature(bento-add-banner): created simple storybook * feature(bento-add-banner): copied CSS from classic * feature(bento-add-banner): added many "stubs" for standalone services * feature(bento-add-banner): ported IOS and Android app logic * feature(bento-add-banner): added platform-aware logic, and dismiss button storage * feature(bento-add-banner): added UI unit tests * feature(bento-add-banner): added IOS tests * feature(bento-add-banner): moved sources into `component` folder * feature(bento-add-banner): added unit tests for Android * feature(bento-add-banner): mapped the `dismiss-button-aria-label` attribute * feature(bento-add-banner): added minor notes to the stories * feature(bento-add-banner): added unit tests for amp-app-banner * feature(bento-add-banner): updated validator * feature(bento-add-banner): extracted services to common location * feature(bento-add-banner): added README for services * feature(bento-add-banner): updated type defs * feature(bento-add-banner): updated formatting * feature(bento-add-banner): lint fix * feature(bento-add-banner): lint ignores * feature(bento-add-banner): lint fixes * feature(bento-add-banner): type fixes * feature(bento-add-banner): updated z-index file * feature(bento-add-banner): updated validator template * feature(bento-add-banner): simplified code with `Array.find` * feature(bento-add-banner): parse meta content using `Array.reduce` * feature(bento-add-banner): added more tests for android * feature(bento-add-banner): added more tests for ios * feature(bento-add-banner): improved tests for BentoAppBanner * feature(bento-add-banner): added tests for Dismiss logic * feature(bento-add-banner): added more iOS tests * feature(bento-add-banner): tiny lint fix * feature(bento-add-banner): improved tests for web-component mode, and fixed the button[open-button] check * feature(bento-add-banner): removed unnecessary `waitFor` * feature(bento-add-banner): lint fix * feature(bento-add-banner): added whitespace in tests * feature(bento-add-banner): ensure tests are not dependent on timers * feature(bento-add-banner): removed obsolete `latestVersion` * feature(bento-add-banner): use `Object.fromEntries` as suggested * feature(bento-add-banner): removed unused CSS * feature(bento-add-banner): use `WindowInterface.getTop` to improve unit tests * feature(bento-add-banner): extracted querySelectorInSlot to core * feature(bento-add-banner): removed useless services, use object-syntax instead of classes, fixed fetchJson * feature(bento-add-banner): renamed services to utils * feature(bento-add-banner): removed redundant win variable * feature(bento-add-banner): extracted parsing logic into separate function for readability * feature(bento-add-banner): renamed file to `docInfo` * feature(bento-add-banner): improved safety of accessing localStorage * feature(bento-add-banner): ensure proper default value is returned * feature(bento-add-banner): removed unnecessary async * feature(bento-add-banner): ensure localStorage still works if `key` changes * feature(bento-add-banner): flip ternary for readability * feature(bento-add-banner): added `self` for fetch * feature(bento-list): generated files from make-extension * feature(bento-add-banner): updated generated z-index file * feature(bento-list): implemented basic async fetching * feature(bento-list): added templating props * feature(bento-list): extracted useAsync * feature(bento-list): simplified template wrappers * feature(bento-list): added multiple tests * feature(bento-list): tested setting 'src' prop * feature(bento-list): updated default template to a simple <p> * feature(bento-list): add aria role attribute to list and listitems * feature(bento-list): added `refresh` method to the API * feature(bento-list): implemented maxItems * feature(bento-list): implemented resetOnRefresh * feature(bento-list): added "Load More" button with infinite query * feature(bento-list): tests for "Load More" button * feature(bento-list): added storybook for "Load More" feature * feature(bento-list): ensure viewport observer works with `rootMargin` * feature(bento-list): implemented "infinite scrolling" via IntersectionObserver * feature(bento-list): reset data when loadMoreBookmark changes * feature(bento-list): ensure requests can be cancelled * feature(bento-list): add jsdoc * feature(bento-list): moved files into `hooks` folder * feature(bento-list): fixed `fetchJson` signature * feature(bento-list): added unit tests for infinite scroll * feature(bento-list): added unit tests for template * feature(bento-list): updated web-component API * feature(bento-list): implemented template engine for AMP mode * feature(bento-list): added unit tests for amp mode * feature(bento-app-banner): ensure XHR rejects invalid status codes * feature(bento-list): updated to current xhr fetchJson signature * feature(bento-list): merging changes from `main` * feature(bento-app-banner): removed dependencies on `/src/url` * feature(bento-app-banner): lint sample code * feature(bento-app-banner): minor code improvements * feature(bento-app-banner): minor code improvements * feature(bento-app-banner): minor code improvements * feature(bento-app-banner): allow localStorage from custom hook * feature(bento-app-banner): include optional `init` param for requests * feature(bento-app-banner): improved logging * feature(bento-app-banner): only expose `logger[info|warn|error]` * feature(bento-app-banner): warn when localStorage.setItem fails * feature(bento-app-banner): ensure logger can be stubbed and tested * feature(bento-app-banner): moved `INVALID_PROTOCOLS` to proper location * feature(bento-app-banner): ensure logger is globally disabled * feature(bento-app-banner): ensure component inherits from AmpPreactBaseElement * feature(bento-app-banner): removed unnecessary `.bind` * feature(bento-list): clean up comments * feature(bento-list): removed obsolete `dict()` wrappers * feature(bento-list): ensure ioOpts are optional * feature(bento-list): removed unused import * feature(bento-list): moved custom hooks to shared folder * feature(bento-list): updated validator template * feature(bento-list): fixed minor lint issues * feature(bento-list): extracted `amp-render` fetch logic, and use it in `amp-list` * feature(bento-list): extracted `collectItemsFromPages` logic * feature(bento-list): use `Preact.isValidElement` * feature(bento-list): documented `useInfiniteQuery` * feature(bento-list): ensure graceful failure when no `src` is supplied * feature(bento-list): added `"npm": true` to amp-list * feature(bento-list): moved component to root folder * feature(bento-list): allow amp-list dependency on amp-render * feature(bento-list): import `isValidElement` from `#preact` * feature(bento-list): simplify logic with `flatMap` * feature(doc-scope): prevent nulls in `flatMap` * feature(bento-list): added types to viewport-observer * feature(bento-list): convert to TS: useStateSafe * feature(bento-list): convert to TS: useLocalStorage * feature(bento-list): convert to TS: useInfiniteQuery * feature(bento-list): convert to TS: useValueRef * feature(bento-list): ensure our IntersectionObserver only responds to the last entry * feature(bento-list): remove unused css * feature(bento-list): added unit tests for loadMoreBookmark * feature(bento-list): removed unused validator files * feature(bento-list): set `hasCss` to false * feature(bento-list): added "loading" spinner and "load more" icon * feature(bento-list): updated "load more" templates to match amp-list 0.1 * feature(bento-list): added empty css file to appease build * feature(bento-list): updated templates to use `load-more` attributes and event delegation * feature(bento-list): replaced `useEventDelegation` with manual delegation, because enzyme. * feature(bento-list): updated `test-amp-list` with new loading spinner * feature(bento-list): removed `hasCss` flag * Revert "feature(bento-list): removed `hasCss` flag" This reverts commit 74d8e24fb552d59ef387a801bb4a7af38f1cd1c1. * feature(bento-list): added `amp-list.js` to shared dep-check-config path Co-authored-by: scottrippey <scott.william.rippey@gmail.com>
* [`bento-reddit`] Add initial changes required for the bento port of the amp-reddit component. * [`bento-reddit`] Add storybook example for preact reddit. * [`bento-reddit`] Update storybook for the preact reddit implementation. * [`bento-reddit`] Update reddit amp mode storybook. * [`bento-reddit`] Update storybook examples to remove `bootstrap` and `src` props. * [`bento-reddit`] Update src/options props to pass the source value to ProxyIframeEmbed. * [`bento-reddit`] Add mappings from props to attrs. * [`bento-reddit`] Add unit tests for the Reddit amp mode. * [`bento-reddit`] Add initial unit tests for the bento implementation of reddit. * [`bento-reddit`] Add Storybook Basic.js for bento-reddit. * [`bento-reddit`] Remove copyright headers where applicable. * [`bento-reddit`] Rename component from 'Reddit' to 'BentoReddit' in preact mode. * [`bento-reddit`] Migrate reddit files to new bento directory. * [`bento-reddit`] Remove unneeded code. * [`bento-reddit`] Add documentation and example file for bento-reddit. * [`bento-reddit`] Update bento-reddit tests. * [`bento-reddit`] Remove unnecessary change to preact/main. * [`bento-reddit`] Update readme and add default title to component. * [`bento-reddit`] Remove unnecessary styling from Basic.js * [`bento-reddit`] remove unnecessary documentation file and update index.html with metadata. * [`bento-reddit`] Add metadata for reddit index.html. * [`bento-reddit`] Increase code coverage in unit tests. * [`bento-reddit`] Rename incorrect css rule and remove unnecessary import. * [`bento-reddit`] Remove accidental reference to bento-facebook. Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com>
* [`bento-reddit`] Add initial changes required for the bento port of the amp-reddit component. * [`bento-reddit`] Add storybook example for preact reddit. * [`bento-reddit`] Update storybook for the preact reddit implementation. * [`bento-reddit`] Update reddit amp mode storybook. * [`bento-reddit`] Update storybook examples to remove `bootstrap` and `src` props. * [`bento-reddit`] Update src/options props to pass the source value to ProxyIframeEmbed. * [`bento-reddit`] Add mappings from props to attrs. * [`bento-reddit`] Add unit tests for the Reddit amp mode. * [`bento-reddit`] Add initial unit tests for the bento implementation of reddit. * [`bento-reddit`] Add Storybook Basic.js for bento-reddit. * [`bento-reddit`] Remove copyright headers where applicable. * [`bento-reddit`] Rename component from 'Reddit' to 'BentoReddit' in preact mode. * [`bento-reddit`] Migrate reddit files to new bento directory. * [`bento-reddit`] Remove unneeded code. * [`bento-reddit`] Add documentation and example file for bento-reddit. * [`bento-reddit`] Update bento-reddit tests. * [`bento-reddit`] Remove unnecessary change to preact/main. * [`bento-reddit`] Update readme and add default title to component. * [`bento-reddit`] Remove unnecessary styling from Basic.js * [`bento-reddit`] remove unnecessary documentation file and update index.html with metadata. * [`bento-reddit`] Add metadata for reddit index.html. * [`bento-reddit`] Increase code coverage in unit tests. * [`bento-reddit`] Rename incorrect css rule and remove unnecessary import. * [`bento-reddit`] Remove accidental reference to bento-facebook. * [`bento-reddit`] Remove unnecessary entry in OWNERS. Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com>
… gallery to src/bento (#37555)
* does not (yet) begin publishing updated versions of extensions to use @bentoproject/core
rileyajones
force-pushed
the
move-bento-src
branch
from
068f7f8
to
e64e12e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be a draft until ampproject/amphtml#36461 lands when I will rebase and fix the git history.
#7