Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Error: Cannot read property 'querySelectorAll' of undefined #69

Open
ampprojectbot opened this issue Mar 16, 2021 · 5 comments
Open

Comments

@ampprojectbot
Copy link
Member

Details

Error report: link
First seen: Nov 24, 2020
Frequency: ~ 2,722/day

Stacktrace

Error: Cannot read property 'querySelectorAll' of undefined
    at querySelectorAll (extensions/amp-next-page/1.0/service.js:695:18)
    at toggleHiddenAndReplaceableElements (extensions/amp-next-page/1.0/service.js:358:13)
    at forEach (extensions/amp-next-page/1.0/service.js:357:7)
    at updateVisibility (extensions/amp-next-page/1.0/service.js:542:13)
    at callback (extensions/amp-next-page/1.0/visibility-observer.js:310:10)
    at updateRelativePos (extensions/amp-next-page/1.0/visibility-observer.js:109:19)
    at handler_ (src/service/position-observer/position-observer-worker.js:109:11)

Notes

@renovate-bot modified extensions/amp-next-page/1.0/service.js:695-695 in #27350 (Mar 30, 2020)
@wassgha modified extensions/amp-next-page/1.0/service.js:358-358 in #26106 (Jan 13, 2020)
@renovate-bot modified extensions/amp-next-page/1.0/service.js:356-357 in #27350 (Mar 30, 2020)
@wassgha modified extensions/amp-next-page/1.0/service.js:541-545 in #26296 (Jan 23, 2020)
@wassgha modified extensions/amp-next-page/1.0/visibility-observer.js:294-381 in #26778 (Apr 9, 2020)
@wassgha modified extensions/amp-next-page/1.0/visibility-observer.js:109-109 in #26778 (Apr 9, 2020)
@zhouyx modified src/service/position-observer/position-observer-worker.js:106-136 in #10813 (Sep 8, 2017)

Seen in:

  • 03-02 Nightly-Control (0156+5)
  • 03-06 Beta (0631+2)
  • 03-06 Experiment-B (0631+2)
  • 03-06 Experimental (0631+2)
  • +13 more

Possible assignees: @wassgha, @zhouyx

/cc @ampproject/release-on-duty

@rcebulko
Copy link
Collaborator

@jridgewell I see the last change to amp-next-page was in ampproject/amphtml@b2b920e#diff-95df70e7313c7d3ea5b4cc3926fae883dbcb3d3e2ed913ee56bda94b26fad27e ; any guess if these are related? This is occurring pretty frequently

@jridgewell
Copy link

Nah, I'm not sure why this is popping up, but it's unrelated. This is running over this.pages_ which contains both Page and HostPage instances. Only HostPage has a .document. So any time we try to call this with a Page, we get an error.

@ampprojectbot
Copy link
Member Author

A duplicate error report was linked to this issue (link)

@ampprojectbot
Copy link
Member Author

A duplicate error report was linked to this issue (link)

@ampprojectbot
Copy link
Member Author

A duplicate error report was linked to this issue (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants